Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #74

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Update README.md #74

merged 1 commit into from
Mar 20, 2022

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Mar 20, 2022

Description

Add Project information, requirements and instructions for running the server locally and in a repository, including instructions for connecting to the MongoDB database and for deploying to Heroku.

Related Issue

Solves #45

Type of change

  • Documentation

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has a self- and/or peer-review of the code been performed?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

@R055A R055A added the documentation Improvements or additions to documentation label Mar 20, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 20, 2022
@R055A R055A self-assigned this Mar 20, 2022
@R055A R055A requested a review from a team as a code owner March 20, 2022 08:05
@R055A R055A linked an issue Mar 20, 2022 that may be closed by this pull request
Update README file. #45
Closed
yuchendong13
yuchendong13 approved these changes Mar 20, 2022
View reviewed changes
Copy link

@yuchendong13 yuchendong13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

kimslor
kimslor approved these changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@kimslor kimslor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hiin3d55 hiin3d55 self-requested a review March 20, 2022 09:29
hiin3d55
hiin3d55 approved these changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@hiin3d55 hiin3d55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@R055A R055A merged commit 8f5b9d3 into SE701-T5:main Mar 20, 2022
@R055A R055A deleted the readme-update branch March 20, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexMiao7 AlexMiao7 AlexMiao7 approved these changes

@yuchendong13 yuchendong13 yuchendong13 approved these changes

@kimslor kimslor kimslor approved these changes

@hiin3d55 hiin3d55 hiin3d55 approved these changes

Assignees

@R055A R055A

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Assignment 1
Development

Successfully merging this pull request may close these issues.

Update README file.
5 participants
@R055A @AlexMiao7 @yuchendong13 @kimslor @hiin3d55