You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Show import history in the Inventory Detail view #1139
See the doc for issue #1108 -- in the detail view, both the records in the imported file, that belong to the same Property record but are different, should be displayed in the Inventory Detail view.
there's a function associated with audit log records
the view has a state, and the state has an audit log
and for any audit log record, you can call the get_import_states() method and that will return a list of the states associated with the individual imports
so the Detail view needs to call that method and then display each of the states that get returned.
The program currently adds a new column each time data is edited in the detail view, so that functionality is working properly. So we just need to also have the import history displaying in this view.
I think at the moment the filename is not being captured at the time of import so even though the history might exist, the filename associated with the import is not being captured. So this represents "lost data" that will not be possible to recover. So we should try to fix this as soon as possible. This represents a departure from the V 1.5 functionality which did capture and display this information.
I am assuming that once this is hooked up it will also show the history of merged records. Now it is impossible to tell which records were merged, except by knowing that there are duplicate matching fields in the original file, and you then have to look at the Inventory list, compare it back to the imported file in a spreadsheet, to see which of the records the program chose as the final "current value". This makes it very difficult to check that all the data was imported properly, and what the program did when it imported the data.
When Nathan does his data migrations from V 1.5 to V 2.0 the program (staging, SHA: d58b5e4 ) shows the history of all the imports. So I think this might not be a display issue. I am wondering if a record is actually being created in the audit table on import.
Activity
RDmitchell commentedon Nov 29, 2016
The Inventory Detail view should also show the edit history of the record, which again should be obtainable from the audit logs.
Here is the original spec for the Building Detail view,
https://drive.google.com/open?id=1KXsJvaWTXmRiER2B1ekQMF0bFq09huo3lNiVqHbBocc
on page 2, item 2-9, says that
RDmitchell commentedon Nov 29, 2016
The program currently adds a new column each time data is edited in the detail view, so that functionality is working properly. So we just need to also have the import history displaying in this view.
[-]Show import states in the Inventory Detail view[/-][+]Show import history in the Inventory Detail view[/+]RDmitchell commentedon Jan 23, 2017
I think at the moment the filename is not being captured at the time of import so even though the history might exist, the filename associated with the import is not being captured. So this represents "lost data" that will not be possible to recover. So we should try to fix this as soon as possible. This represents a departure from the V 1.5 functionality which did capture and display this information.
RDmitchell commentedon Feb 6, 2017
I am assuming that once this is hooked up it will also show the history of merged records. Now it is impossible to tell which records were merged, except by knowing that there are duplicate matching fields in the original file, and you then have to look at the Inventory list, compare it back to the imported file in a spreadsheet, to see which of the records the program chose as the final "current value". This makes it very difficult to check that all the data was imported properly, and what the program did when it imported the data.
RDmitchell commentedon Feb 22, 2017
When Nathan does his data migrations from V 1.5 to V 2.0 the program (staging, SHA: d58b5e4 ) shows the history of all the imports. So I think this might not be a display issue. I am wondering if a record is actually being created in the audit table on import.
Initial audit history changes #1139
RDmitchell commentedon Mar 23, 2017
instance: dev1
SHA: 0f23403
This seems to be working. Am closing and will open other issues if I find problems or bugs.