Skip to content

List Settings: Property and Tax Lot indicators are not always correct, depending on the mapping #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RDmitchell opened this issue Dec 16, 2016 · 6 comments

Comments

@RDmitchell
Copy link

RDmitchell commented Dec 16, 2016

SHA: 341f613
instance: seeddemostaging
browser: chrome, incognito
files: covered-buildings-sample.csv (standard sample file)
org; LBNL 404 (completely new org for this test)

Folder with sample file, including VIDEO showing this behavior
https://drive.google.com/open?id=0B3fTKpZ9Dx7LQTRLMU10TGhaSDA

I think the issue with List Settings might have to do with the fact that a single file is getting mapped to both Tax Lot and Property fields, although I could be wrong.

Watch the video (see link above) for details.

Here are the main steps -- I have highlighted 3 problems, Only PROBLEM # 2 is relevant to this issue. I will create separate issues for the other 2 problems.

  • Import covered-buildings-sample.csv as a spreadsheet
  • map some fields to Tax Lot, some to Property
    image
  • save mapping, match, view in inventory list
  • PROBLEM # 1 -- only one record in Property table, should be 512
    image
  • Inventory List - View by Tax Lot -- 512 records -- correct
  • The default fields displayed in the list don't include all the records I mapped
  • go to Tax Lot / List Settings
  • PROBLEM # 2 -- find the fields mapped to Tax Lot -- some of them have the "property" tag rather than no tag
    image
  • PROBLEM # 3 -- one of the fields has 3 entries in List Settings with the same name -- don't know which to pick
    image
@RDmitchell
Copy link
Author

Here is another video (from #1103) that also shows the problem

https://drive.google.com/open?id=0B3fTKpZ9Dx7LUGdROTJZVlRyN0U

@RDmitchell
Copy link
Author

instance: seeddemostaging
SHA: 3a6051b
browser: chrome, incognito
org: RM 88 (DC)

Here is another example this issue
image

@RDmitchell RDmitchell changed the title List Settings reverses Property and Tax Lot indicators when one file mapped to both tables List Settings: Property and Tax Lot indicators are not always correct, depending on the mapping Jan 21, 2017
@RDmitchell
Copy link
Author

instance: seeddev
SHA: 3daf0f8 (2.0 release)
browser: chrome, incognito
file: covered-building-list.csv (standard file)
see isssue #1217 for mapping

  • Imported file, mapped all to tax lot, matched.
  • Inventory, View by Tax Lot (the only data at this point is tax lot data):
    image
  • Click on List Settings -- If I select only the fields that were in the imported file and mapped, this is what I see. Several of the fields have the indicators "Property", even though they were all mapped to the Tax Lot table. I understand that these are fields that are structured fields in the Property table, but in this case, because they were mapped to the Tax Lot table, they will be extra data and it is really not relevant to the user that they are normally found in the Property Table. So I think this indicator is not relevant and should not be displayed.
    image

@RDmitchell
Copy link
Author

instance: seeddev
SHA: d43a0fa
org: LBNL 406 -- made completely new for this test so that there is no history of previous mapping anywhere
Files
Covered-building-sample.csv
portfolio-manager-sample.csv

Each file mapped to just one table, each with different field names, in same data set

  • Import covered building file

  • Mapping
    All fields mapped to Tax Lot table
    Matching fields are Jurisdiction Tax Lot ID and Address Line 1
    image

  • Save mapping, match

  • Inventory: Tax Lot List Settings
    image

  • Inventory: Tax Lot List view
    image

  • Import Portfolio manager file (same dataset)

  • Mapping
    All fields mapped to Property Table
    Matching fields are PM Property ID and Address Line 1
    image
    Save mapping, match

  • Inventory: Property List Settings

  • see Program is automatically mapping Energy score to ENERGY STAR Score but it doesn't display in mapping #1265 for issue of ENERGY STAR Score showing mapping to Energy Score (default) but shows up in Property List Settings as ENERGY STAR Score
    image

  • Inventory: Property List View
    Address Line 2 and Property name are set to "Not Available" in the original file, which is turned into "blank" in the imported data, so those fields, properly, have no data. All the other fields have data
    image

@RDmitchell
Copy link
Author

instance: seeddev
SHA: d43a0fa
org: LBNL 406 -- used same org as the test above, without deleting inventory or mapping
Files
MixedPropTaxLotData.xlsx from #1128

Map fields in one file to both Property and Tax Lot tables

  • Import into new data set, same cycle
  • Mapping
    1 matching field for Property = Custom ID 1
    1 matching field for Tax lot = Jurisdiction Tax Lot ID
    image
  • Save mapping, match
  • Inventory: Property List Settings
    image
  • Inventory: Property List View
    image
  • Inventory: Tax List Settings
    image
  • Inventory: Tax Lot View -- all fields show correct data
    image
  • Inventory: Tax Lot List Setttings -- pick fields from the Property table and they are correctly tagged with"property"
    image
  • Inventory: Tax Lot View -- shows both Tax lot and property fields with their correct relationship
    image
  • Inventory: Property List settings -- pick fields from the Tax Lot table and they are correctly tagged with "tax lot"
    image
  • Inventory: Property List View
    All tax lot fields are displayed -- no data showing for Tax Lot City, State and Postal Code, have put that in a new issue A few mapped Tax Lot fields are not showing data in the Property List view (City, State, Postal Code) #1263
    image

@RDmitchell
Copy link
Author

The tags indicating whether fields are from the Property and Tax Lot tables in the Property and Tax Lot List Settings seem to be behaving much better than they were.

Am closing this. If I run into new issues along these lines, I will open a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant