Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Revise conditions in init_startstop_service(). #39

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
4 participants
@pebenito
Copy link
Member

commented Mar 22, 2019

The role transition for directly executing an init script should only
happen if direct_sysadm_daemon is enabled and only on non-systemd
systems.

@perfinion
@bigon
@fishilico
@bachradsusi

@perfinion

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

@pebenito Hm this looks like it changes things around for Gentoo? I want to be able to have both OpenRC and systemd enabled for Gentoo. The migration path requires rebuilding the policies to enable systemd first when still on OpenRC and the user should be able to reboot between both without any trouble.

Thats why I originally had the ifdef's for systemd and openrc in separate blocks. Is there a better way to do this?

@pebenito

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

I'm ok putting it back outside the systemd ifdef. This is why I explicitly requested the review. :)

@pebenito pebenito force-pushed the pebenito:revise-init-stopstart branch from 4a7d2a0 to 35fb860 Mar 25, 2019

@pebenito

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

I'd prefer that all 4 people mentioned state that there are no concerns before I merge this.

@bachradsusi

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

No concerns from my side. According to @wrabcak neither Fedora nor Red Hat Enterprise Linux would be affected by this change.

@perfinion
Copy link
Member

left a comment

Looks fine to me now :)

@etbe

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

I think it would be good to support both systemd and non-systemd on Debian. This change does make the policy less ugly which is a good thing.

@pebenito

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

@etbe I'm taking to mean there are no objections?

init: Revise conditions in init_startstop_service().
Signed-off-by: Chris PeBenito <Christopher.PeBenito@microsoft.com>

@pebenito pebenito force-pushed the pebenito:revise-init-stopstart branch from 35fb860 to b06126d Apr 5, 2019

@pebenito

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

I decided to simply flatten it out.

@pebenito pebenito merged commit b06126d into SELinuxProject:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.