Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please migrate to the new Fedora translation platform #198

Closed
Jibec opened this issue Jan 9, 2020 · 11 comments
Closed

please migrate to the new Fedora translation platform #198

Jibec opened this issue Jan 9, 2020 · 11 comments

Comments

@Jibec
Copy link

Jibec commented Jan 9, 2020

Hello, the Fedora project migrates its translation platform to Weblate [1].

This tool directly interact with your git repository, and requires us to know:

  • [mandatory] which branch is your development branch?
  • [mandatory] have you merged latest translation from Zanata and locked the project?
  • [info] Weblate will handle updates when pot file changes, don't edit po files for this [2]
  • [optional] what is the license of translation? (please use a code from https://spdx.org/licenses/)
  • [optional] do you have any announcement/warning you would like to display to the translators? (it will be displayed in Weblate)
  • [optional] do you need us to activate any specific checks? (this is a setting per component [3])
  • [optional] do you need us to automatically detect new translation files? (typical usecase: website translation with one translation file per page)

Please note:

  • For github and gitlab hosted projects, Weblate open pull request. For other git hosting, you'll have to add a key to allow commits.
  • In Weblate's vocable, one project is a group of component. Each component is a translation file. You can have many projects or many components or both.
  • You can change your mind over time, just reach trans@lists.fedoraproject.org

[1] https://communityblog.fedoraproject.org/fedora-localization-platform-migrates-to-weblate/
[2] https://docs.weblate.org/en/latest/admin/continuous.html#avoiding-merge-conflicts
[3] https://docs.weblate.org/en/latest/user/checks.html#translation-checks

Concerned project: https://fedora.zanata.org/project/view/selinux

@bachradsusi
Copy link
Member

This repository doesn't use Zanata. The correct repository according to zanata project home page is https://github.com/fedora-selinux/selinux - fedora-selinux/selinux#59

@Jibec
Copy link
Author

Jibec commented Jan 14, 2020 via email

@bachradsusi
Copy link
Member

The problem with translations is that they generate big patches. In Fedora we don't patch the repository directly but we create tarball from downloaded translations from Zanata, and use them during build, see https://src.fedoraproject.org/rpms/policycoreutils/blob/master/f/README.translations Also we split translation in Fedora into subproject to follow the directory and release tarballs structure.

In this project, the translations haven't been updated for several releases, there are just minor type fixes. It needs to be reconsidered and this discussion should happen on SELinux mailing list - selinux@vger.kernel.org.

@bachradsusi
Copy link
Member

So my suggestion is to migrate fedora-selinux/selinux project (which uses https://fedora.zanata.org/project/view/selinux) first, and then start a discussion about translation in this project on its mailling list

@Jibec
Copy link
Author

Jibec commented Jan 14, 2020 via email

@vmojzis
Copy link
Contributor

vmojzis commented Aug 17, 2020

@Jibec Is there any advantage in having a dedicated translation repository if we only intend to include the translations with our releases (and not store them in the source repository)? I was thinking of just using weblate client to download the latest translations when we need them (as opposed to having it push updates to a dedicated repository).

@Jibec
Copy link
Author

Jibec commented Aug 17, 2020 via email

@bachradsusi
Copy link
Member

I don't get it. Why we need a new repo when weblate is able to use .pots file from our existing repo and we can download translations from weblate?

@bachradsusi
Copy link
Member

Anyway, this discussion should be in fedora-selinux/selinux#59

@Jibec
Copy link
Author

Jibec commented Aug 18, 2020

you have a specific way of organizing your repositories that I don't understand, and you didn't explain how you work.

Fedora contribute upstream.
If fedora-selinux is a fork of selinux project with specific Fedora rules, then there is no translation to do in Fedora-selinux and adding all to selinux directly.

If for some reasons, the fork is the only way to do, then we could add both to the translation platform, so that translators contribute both projects (Weblate handles this nicely).

Fedora moved to Weblate, Zanata will stop.
Weblate have a specific behavior which provides nice and easy integration with git repositories and translators.
I suggest you to keep it simple, include translations in your code.

You want smaller patches? I can remove line numbers in po files, saving a lot in diffs.
You want less commits? We can use git squash.
You want signoff? We can add this too.

You don't want translators contribution in your repository and/or your github organization?
Well, why do allow translation at all?

Note it looks like selinux:

why should each distribution have to translate the same thing?

@bachradsusi
Copy link
Member

#198 (comment) and #198 (comment) are still valid. I'm willing to implement/propose/update/maintain translations in this repository later when it's implemented for fedora-selinux/selinux and when it's clear how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants