From 2c18f084425afa9d60dcc4fdd766a79a233cd728 Mon Sep 17 00:00:00 2001 From: Chris Thrasher Date: Mon, 16 Sep 2024 16:11:55 -0400 Subject: [PATCH] Assert string arguments are not null For these functions, providing a null pointer argument would result in invoking undefined behavior. --- src/CSFML/Audio/SoundBufferRecorder.cpp | 1 + src/CSFML/Audio/SoundRecorder.cpp | 1 + src/CSFML/Graphics/Image.cpp | 1 + 3 files changed, 3 insertions(+) diff --git a/src/CSFML/Audio/SoundBufferRecorder.cpp b/src/CSFML/Audio/SoundBufferRecorder.cpp index 55e6cd04..a36f56a5 100644 --- a/src/CSFML/Audio/SoundBufferRecorder.cpp +++ b/src/CSFML/Audio/SoundBufferRecorder.cpp @@ -81,6 +81,7 @@ const sfSoundBuffer* sfSoundBufferRecorder_getBuffer(const sfSoundBufferRecorder bool sfSoundBufferRecorder_setDevice(sfSoundBufferRecorder* soundBufferRecorder, const char* name) { assert(soundBufferRecorder); + assert(name); return soundBufferRecorder->This.setDevice(name); } diff --git a/src/CSFML/Audio/SoundRecorder.cpp b/src/CSFML/Audio/SoundRecorder.cpp index 1fdd1d2b..80af68f6 100644 --- a/src/CSFML/Audio/SoundRecorder.cpp +++ b/src/CSFML/Audio/SoundRecorder.cpp @@ -113,6 +113,7 @@ const char* sfSoundRecorder_getDefaultDevice() bool sfSoundRecorder_setDevice(sfSoundRecorder* soundRecorder, const char* name) { assert(soundRecorder); + assert(name); return soundRecorder->This.setDevice(name); } diff --git a/src/CSFML/Graphics/Image.cpp b/src/CSFML/Graphics/Image.cpp index d7015ce0..778895b1 100644 --- a/src/CSFML/Graphics/Image.cpp +++ b/src/CSFML/Graphics/Image.cpp @@ -122,6 +122,7 @@ bool sfImage_saveToMemory(const sfImage* image, sfBuffer* output, const char* fo { assert(image); assert(output); + assert(format); auto data = image->This.saveToMemory(format);