Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Loading shaders from stream broken? #21

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Not sure if this is a bug, or I don't know how to use the interface.
I first thought it had something to do with one of the shader streams being null, which is supported according to the documentation, so I tried to solve it as attached, but it still doesn't work: sfShader_createFromStream(...) returns null, anyways.

Loading shaders from stream broken?
Not sure if this is a bug.

Nevermind, the above patch does solve the issue for me.

Owner

LaurentGomila commented Jul 2, 2013

Thanks. But I'd rather fix StreamAdaptor directly (it should initialize its InputStreamPtr only if the source stream is not null).

Yes, of course. I just wanted my copy work now :)
BTW, there is some functionality missing from the .Net port that is present in C++. I understand in the case of System and Network modules, that is not necessary, but there are also parts of the rest of the API missing, e.g. some Vector2f methods (like dot product).
Do you want me to commit patches (relatively simple stuff), prefer to do it yourself, or, for some reason, decided not to implement those things at all?

Owner

LaurentGomila commented Jul 3, 2013

Yes, of course. I just wanted my copy work now :)

So do you want me to close this pull request and implement a proper fix, or do you want to modify your patch accordingly?

there are also parts of the rest of the API missing, e.g. some Vector2f methods (like dot product).

There's no dot product in SFML. What else is missing? :p

Do you want me to commit patches (relatively simple stuff), prefer to do it yourself, or, for some reason, decided not to implement those things at all?

First report everything that you found, before doing anything.

There's no dot product in SFML

Uhm... I got confused with some other library's Vector class, nevermind. Why are the classes sealed, by the way? Performance concerns?

First report everything that you found, before doing anything.

Ok.

Owner

LaurentGomila commented Jul 3, 2013

Why are the classes sealed, by the way?

Are they? I don't remember using the sealed keyword anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment