New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only lowercase keypresses are handled on Linux #1012

Closed
SMemsky opened this Issue Dec 2, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@SMemsky

SMemsky commented Dec 2, 2015

In WindowImplX11.cpp function "keysymToSF(xcb_keysym_t symbol)" handles only lowercase KeySym's(XK_a, XK_b, e.t.c.).
This causes SFML to generate sf::Keyboard::Unknown keycodes in button events when CapsLock and/or L/RShift is pressed.
As of Xlib manual uppercase presses are generated too and they should be handled as XK_A, XK_B, e.t.c.

I'm running Linux 3.19.0-33-generic Ubuntu-14.04.1 i686

@binary1248 binary1248 self-assigned this Dec 24, 2015

@binary1248 binary1248 added this to the 2.4 milestone Dec 24, 2015

binary1248 added a commit that referenced this issue Dec 24, 2015

Fixed modifiers causing sf::Keyboard::Unknown being returned in key e…
…vents on Unix (#1012). On Unix, SFML now tries harder to create proper key events on keyboards that shift keys which are typically unshifted on QWERTY layouts (this makes the numeric codes usable even on AZERTY layouts).

@eXpl0it3r eXpl0it3r added s:accepted and removed s:undecided labels Dec 24, 2015

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Dec 24, 2015

Member

@SMemsky can you try out the patch I submitted in #1022?

Member

binary1248 commented Dec 24, 2015

@SMemsky can you try out the patch I submitted in #1022?

@SMemsky

This comment has been minimized.

Show comment
Hide comment
@SMemsky

SMemsky Jan 2, 2016

Yes, patch seems to fix this problem on Ubuntu 14.04 with qwerty layout.

SMemsky commented Jan 2, 2016

Yes, patch seems to fix this problem on Ubuntu 14.04 with qwerty layout.

eXpl0it3r added a commit that referenced this issue May 10, 2016

Fixed modifiers causing sf::Keyboard::Unknown being returned in key e…
…vents on Unix (#1012). On Unix, SFML now tries harder to create proper key events on keyboards that shift keys which are typically unshifted on QWERTY layouts (this makes the numeric codes usable even on AZERTY layouts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment