New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: iOS orientation change handling re-scales window size by backingScaleFactor #1049

Closed
louis-langholtz opened this Issue Jan 26, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@louis-langholtz
Contributor

louis-langholtz commented Jan 26, 2016

After creating an sf::RenderWindow under iOS getSize() returns 640 by 960 (on an iPhone 4S at least running in the simulator). This size matches the pixel unit size of what's expected according to the technical specs for the iPhone 4S.

But after changing the device's orientation (rotating the device left or right) a Resized event is generated that gives width and height values that are a factor of two larger than the original size. This factor of two, is the value of the SFML iOS application delegate's backingScaleFactor variable (for this device) and it's being re-applied in the deviceOrientationDidChange method (in sfml-window/ios/SFAppDelegate.mm) to the size returned from self.sfWindow->getSize() (which already factors this value in).

louis-langholtz added a commit to louis-langholtz/SFML that referenced this issue Jan 26, 2016

louis-langholtz added a commit to louis-langholtz/SFML that referenced this issue Mar 16, 2016

@eXpl0it3r eXpl0it3r added this to the 2.4.1 milestone Aug 11, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 6, 2016

Member

Superseded by #1050

Member

eXpl0it3r commented Sep 6, 2016

Superseded by #1050

@eXpl0it3r eXpl0it3r closed this Sep 6, 2016

@eXpl0it3r eXpl0it3r self-assigned this Sep 6, 2016

@eXpl0it3r eXpl0it3r removed the s:accepted label Sep 6, 2016

eXpl0it3r added a commit that referenced this issue Sep 13, 2016

eXpl0it3r added a commit that referenced this issue Sep 13, 2016

eXpl0it3r added a commit that referenced this issue Oct 24, 2016

jmcmorris pushed a commit to jmcmorris/SFML that referenced this issue Jan 3, 2017

iamPHEN added a commit to Bablawn3d5/SFML that referenced this issue Mar 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment