New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sf::Packet::operator<<(const char*) should use strlen #118

Closed
Fanael opened this Issue Oct 31, 2011 · 0 comments

Comments

Projects
None yet
2 participants
@Fanael

Fanael commented Oct 31, 2011

Currently it uses hand-written code that calculates the length of a string. Is there any particular reason to do that? strlen is faster to write, it's arguably more readable, it most probably runs faster, it's generally better.
Same goes for sf::Packet::operator<<(const wchar_t*) and wcslen.

@ghost ghost assigned LaurentGomila Oct 31, 2011

LaurentGomila added a commit that referenced this issue Jun 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment