New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sf::Http lacks support for PUT and DELETE request methods #257

Closed
MorleyDev opened this Issue Jul 17, 2012 · 6 comments

Comments

Projects
None yet
5 participants
@MorleyDev

MorleyDev commented Jul 17, 2012

At present sf::Http::Request does not support the PUT and DELETE methods of sending Http requests.

These are often sent by clients being used in a REST architecture, and as such support for them would aid in people creating networked games (for example).

Implementing this would require adding to the sf::Http::Request::Method enumerator the related values, and modifying the sf::Http::SendRequest function to send http requests correctly using these new methods.

Upon some examination, it looks like the change may simply require modifying the std::string Http::Request::prepare() const function in SFML/Network/Http.cpp by adding:

case Put: method = "PUT"; break;
case Delete: method = "DELETE"; break;

after line 111. And adding to include/SFML/Network/Http.hpp

Put,
Delete,

after line 65.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 22, 2014

Member

@LaurentGomila and everyone else, do we need to further discuss this or could a modified version of @firefly2442's PR get merged?

Member

eXpl0it3r commented May 22, 2014

@LaurentGomila and everyone else, do we need to further discuss this or could a modified version of @firefly2442's PR get merged?

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 May 22, 2014

Member

I'll get a feature branch up in 10 minutes.

Member

binary1248 commented May 22, 2014

I'll get a feature branch up in 10 minutes.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini May 22, 2014

Member

We could also move it to 2.2.

Member

mantognini commented May 22, 2014

We could also move it to 2.2.

@eXpl0it3r eXpl0it3r modified the milestones: 2.2, 2.x May 22, 2014

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 22, 2014

Member

You have as much edit rights as anyone else, but I did it for you. 😉

@binary1248 Great!

Member

eXpl0it3r commented May 22, 2014

You have as much edit rights as anyone else, but I did it for you. 😉

@binary1248 Great!

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini May 22, 2014

Member

@eXpl0it3r I should have put a question mark at the end of my question. ^^'

Member

mantognini commented May 22, 2014

@eXpl0it3r I should have put a question mark at the end of my question. ^^'

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 22, 2014

Member

Merged in 749cbb2

Member

eXpl0it3r commented May 22, 2014

Merged in 749cbb2

@eXpl0it3r eXpl0it3r added the resolved label May 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment