New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False internal OpenGL errors #340

Closed
danijar opened this Issue Jan 21, 2013 · 4 comments

Comments

Projects
None yet
4 participants
@danijar
Contributor

danijar commented Jan 21, 2013

The function "glCheck()" is used after each internal OpenGL call. But if the user uses it's own OpenGL calls, the error checking can fire false positives. For example when the user produces an OpenGL error but didn't fetch it, the at SFML's next OpenGL call "glCheck()" will print in error, which actually isn't located at that file.

Maybe it can be fixed by checking for OpenGL errors before each batch of internal OpenGL calls and if positive, tell the user something like "There was an OpenGL error caused by the user". (By user I mean the developer who uses the SFML framework)

@Qix-

This comment has been minimized.

Show comment
Hide comment
@Qix-

Qix- Jan 21, 2013

. . . used after each internet OpenGL . . .

Qix- commented Jan 21, 2013

. . . used after each internet OpenGL . . .

@danijar

This comment has been minimized.

Show comment
Hide comment
@danijar

danijar Jan 21, 2013

Contributor

Thanks, I corrected the typo.

Contributor

danijar commented Jan 21, 2013

Thanks, I corrected the typo.

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Jan 23, 2013

Member

As with saving/restoring context settings, I don't think this should happen by default, because it will add additional overhead for people not using custom calls or doing proper error checking. On the other side, I could imagine some cleanup such as this in PopGLStates() (maybe optional).

Member

MarioLiebisch commented Jan 23, 2013

As with saving/restoring context settings, I don't think this should happen by default, because it will add additional overhead for people not using custom calls or doing proper error checking. On the other side, I could imagine some cleanup such as this in PopGLStates() (maybe optional).

@ghost ghost assigned LaurentGomila Jan 25, 2013

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Jun 19, 2013

Member

It can (and should) definitely happen in pushGLStates(), since this function is supposed to be called whenever user switches from custom OpenGL to SFML.

Performance is not a concern, these checks are only done in debug mode.

Member

LaurentGomila commented Jun 19, 2013

It can (and should) definitely happen in pushGLStates(), since this function is supposed to be called whenever user switches from custom OpenGL to SFML.

Performance is not a concern, these checks are only done in debug mode.

LaurentGomila added a commit that referenced this issue Jul 6, 2013

Checking errors in RenderTarget::pushGLStates() to avoid generating f…
…alse error messages when user leaves unchecked OpenGL errors (#340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment