New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetVersionEx is deprecated #469

Closed
retep998 opened this Issue Sep 18, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@retep998

retep998 commented Sep 18, 2013

Visual Studio 2013 emits the following warning when compiling SFML.

4>..\..\..\..\src\SFML\Window\Win32\WindowImplWin32.cpp(887): warning C4996: 'GetVersionExA': was declared deprecated
4>          C:\Program Files (x86)\Windows Kits\8.1\Include\um\sysinfoapi.h(433) : see declaration of 'GetVersionExA'

Probably someone should look into an alternative method that isn't deprecated.

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Sep 18, 2013

Member

Yeah, noticed that as well. I'd even consider dropping the whole handling (and only use the Unicode functions), as I don't believe anyone will really try to compile SFML for Windows 9x anymore, plus I'm not even sure whether those old versions would even support this call at all (think it got added in Windows 98; but might be wrong).

Member

MarioLiebisch commented Sep 18, 2013

Yeah, noticed that as well. I'd even consider dropping the whole handling (and only use the Unicode functions), as I don't believe anyone will really try to compile SFML for Windows 9x anymore, plus I'm not even sure whether those old versions would even support this call at all (think it got added in Windows 98; but might be wrong).

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Sep 19, 2013

Member

Yes, removing all the pre-XP stuff is what I planned to do ;)

Member

LaurentGomila commented Sep 19, 2013

Yes, removing all the pre-XP stuff is what I planned to do ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment