New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add up vector to sf::Listener #545

Closed
Bromeon opened this Issue Mar 7, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@Bromeon
Member

Bromeon commented Mar 7, 2014

The sf::Listener class currently does not allow full 3D spatialization, as it provides only access to the position and the direction (at vector) in its interface. Giving access to the up vector will make it possible to employ the SFML audio module in 3D scenarios, using orthogonal (and not skewed) coordinate systems.

Forum thread: http://en.sfml-dev.org/forums/index.php?topic=14566

@Bromeon Bromeon added this to the 2.x milestone Mar 7, 2014

@Bromeon Bromeon added feature labels Mar 7, 2014

@Bromeon Bromeon self-assigned this Mar 7, 2014

@criptych

This comment has been minimized.

Show comment
Hide comment
@criptych

criptych Mar 7, 2014

Had actually started doing this myself for other reasons, but here's what I've got.

criptych commented Mar 7, 2014

Had actually started doing this myself for other reasons, but here's what I've got.

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Mar 7, 2014

Member

Thanks. But the modification is really simple, it takes much more time to review and correct pull requests ;)

Apart from that, we're going to use a different API than suggested (a separate attribute for the up vector).

Member

Bromeon commented Mar 7, 2014

Thanks. But the modification is really simple, it takes much more time to review and correct pull requests ;)

Apart from that, we're going to use a different API than suggested (a separate attribute for the up vector).

@criptych

This comment has been minimized.

Show comment
Hide comment
@criptych

criptych Mar 7, 2014

it takes much more time to review and correct pull requests

Sorry, didn't know that.

Apart from that, we're going to use a different API than suggested (a separate attribute for the up vector).

I may just have to steal borrow that idea. :)

criptych commented Mar 7, 2014

it takes much more time to review and correct pull requests

Sorry, didn't know that.

Apart from that, we're going to use a different API than suggested (a separate attribute for the up vector).

I may just have to steal borrow that idea. :)

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Mar 7, 2014

Member

This wasn't meant in general, we really appreciate pull requests and support from the community. It's just that this specific feature is a few lines of code, and it takes both pull requesters and reviewers a lot of time. There's no need to apologize :)

You don't have to steal the idea, as it will soon be in SFML ;)

Member

Bromeon commented Mar 7, 2014

This wasn't meant in general, we really appreciate pull requests and support from the community. It's just that this specific feature is a few lines of code, and it takes both pull requesters and reviewers a lot of time. There's no need to apologize :)

You don't have to steal the idea, as it will soon be in SFML ;)

@criptych

This comment has been minimized.

Show comment
Hide comment
@criptych

criptych Mar 7, 2014

All right.

You don't have to steal the idea, as it will soon be in SFML ;)

Right, I just meant reverting my changes to use the "official" new API.

criptych commented Mar 7, 2014

All right.

You don't have to steal the idea, as it will soon be in SFML ;)

Right, I just meant reverting my changes to use the "official" new API.

@Bromeon Bromeon modified the milestones: 2.x, 2.2 Mar 23, 2014

@Bromeon Bromeon closed this in 50e3052 Mar 23, 2014

@Bromeon Bromeon added the resolved label Mar 23, 2014

MarioLiebisch added a commit to MarioLiebisch/SFML that referenced this issue Apr 15, 2014

@Bromeon Bromeon removed their assignment Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment