New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"SGIS_texture_edge_clamp unavailable" but "GL_EXT_texture_edge_clamp: OK" #880

Closed
oprypin opened this Issue May 10, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@oprypin
Contributor

oprypin commented May 10, 2015

OpenGL extension SGIS_texture_edge_clamp unavailable
Artifacts may occur along texture edges

Many people seem to be getting this warning now. And I have indeed noticed artifacts along texture edges, but the same happened in older versions. As I understand it, the problem was always there, just that the warning message appeared only in SFML 2.3.

I have this on an old NVIDIA graphics card, other people reported the same on new ones.

And the thing is...

glewinfo | grep texture_edge_clamp
GL_EXT_texture_edge_clamp:                                     OK 
GL_SGIS_texture_edge_clamp:                                    MISSING 

Some graphics cards seem to have this feature under a different name. It may be worth adding a fallback like this.

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 May 10, 2015

Member

Hmm... I guess Nvidia doesn't think it makes sense to expose the same extension under its aliases like everybody else does. Will fix.

As I understand it, the problem was always there, just that the warning message appeared only in SFML 2.3.

It definitely wasn't always there, because there was never a problem. 😉

This "issue" has only became apparent now after we added support for hardware that doesn't support texture edge clamping, because I guess not many people with Nvidia cards have tested/reported the issue after the commit got merged.

Member

binary1248 commented May 10, 2015

Hmm... I guess Nvidia doesn't think it makes sense to expose the same extension under its aliases like everybody else does. Will fix.

As I understand it, the problem was always there, just that the warning message appeared only in SFML 2.3.

It definitely wasn't always there, because there was never a problem. 😉

This "issue" has only became apparent now after we added support for hardware that doesn't support texture edge clamping, because I guess not many people with Nvidia cards have tested/reported the issue after the commit got merged.

binary1248 added a commit that referenced this issue May 10, 2015

Added support for GL_EXT_texture_edge_clamp as well since some GL imp…
…lementations don't expose GL_SGIS_texture_edge_clamp even when clamp-to-edge functionality is supported. Fixes #880
@binary1248

This comment has been minimized.

Show comment
Hide comment
Member

binary1248 commented May 10, 2015

@eXpl0it3r eXpl0it3r added this to the 2.3.1 milestone May 11, 2015

binary1248 added a commit that referenced this issue May 20, 2015

Added support for GL_EXT_texture_edge_clamp as well since some GL imp…
…lementations don't expose GL_SGIS_texture_edge_clamp even when clamp-to-edge functionality is supported. Fixes #880
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 22, 2015

Member

Superseded and fixed by #882

Member

eXpl0it3r commented May 22, 2015

Superseded and fixed by #882

@eXpl0it3r eXpl0it3r closed this May 22, 2015

@eXpl0it3r eXpl0it3r added s:superseded and removed s:accepted labels May 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment