New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Added sf::getNativeActivity() #1005

Merged
merged 1 commit into from Apr 22, 2016

Conversation

4 participants
@MarioLiebisch
Member

MarioLiebisch commented Nov 18, 2015

This is only implemented for Android builds and requires the user to use an implicit include for the sub-header.

This will trigger a compiler error on other platforms, if they try to include this header file.

To see actual usage, check the updated Android example.

Feel free to post comments regarding the actual code change as well as the doxygen additions (two aliases to make such notes easier in the future).

This PR addresses issue #680.

@Tardo

This comment has been minimized.

Show comment
Hide comment
@Tardo

Tardo Dec 2, 2015

+1 I'm using this PR... now not need do a ugly hack :D

Tardo commented Dec 2, 2015

+1 I'm using this PR... now not need do a ugly hack :D

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 29, 2016

Member

@MarioLiebisch Do you feel this PR is ready to be merged?

Member

eXpl0it3r commented Mar 29, 2016

@MarioLiebisch Do you feel this PR is ready to be merged?

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Mar 29, 2016

Member

If others are okay regarding the current additions to Doxygen and stuff, yes.

Member

MarioLiebisch commented Mar 29, 2016

If others are okay regarding the current additions to Doxygen and stuff, yes.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 29, 2016

Member

How do the Doxygen changes look like?

Member

eXpl0it3r commented Mar 29, 2016

How do the Doxygen changes look like?

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 20, 2016

Member

Took me a bit to find the doc for it, but it seems fine:

NativeActivity

Anything else? Otherwise I'd add it to the merge list.

Member

eXpl0it3r commented Apr 20, 2016

Took me a bit to find the doc for it, but it seems fine:

NativeActivity

Anything else? Otherwise I'd add it to the merge list.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Apr 20, 2016

Member

The doc looks good. 👍

/details:on
But I'm wondering if the four commas in the doc text are actually superfluous...
/details:off

Member

mantognini commented Apr 20, 2016

The doc looks good. 👍

/details:on
But I'm wondering if the four commas in the doc text are actually superfluous...
/details:off

@eXpl0it3r eXpl0it3r added s:accepted and removed s:undecided labels Apr 20, 2016

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Apr 21, 2016

Member

Despite me still not being 100% happy/sure about the extra header stuff, everything fine by me for now. So even if we still want to change this again, it's a really essential part to allow users to extend their code beyond the interfaces SFML provides. As such I'd rather merge it now than at any later point in time, even if that would mean potentially changing the API again.

Member

MarioLiebisch commented Apr 21, 2016

Despite me still not being 100% happy/sure about the extra header stuff, everything fine by me for now. So even if we still want to change this again, it's a really essential part to allow users to extend their code beyond the interfaces SFML provides. As such I'd rather merge it now than at any later point in time, even if that would mean potentially changing the API again.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 21, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Apr 21, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Android: Added `sf::getNativeActivity()` to retrieve a handle to the …
…current activity

This is only implemented for Android builds and requires the user to include the sub-header specifically. Other platforms will trigger a compiler error, if they try to include this header file.

@eXpl0it3r eXpl0it3r merged commit 9f6f02f into master Apr 22, 2016

14 checks passed

debian-gcc-64 Build #115 done.
Details
freebsd-gcc-64 Build #115 done.
Details
osx-clang-universal Build #120 done.
Details
static-analysis Build #115 done.
Details
windows-gcc-492-tdm-32 Build #1 done.
Details
windows-gcc-492-tdm-64 Build #1 done.
Details
windows-gcc-530-mingw-32 Build #1 done.
Details
windows-gcc-530-mingw-64 Build #1 done.
Details
windows-vc11-32 Build #117 done.
Details
windows-vc11-64 Build #118 done.
Details
windows-vc12-32 Build #117 done.
Details
windows-vc12-64 Build #116 done.
Details
windows-vc14-32 Build #116 done.
Details
windows-vc14-64 Build #118 done.
Details

@eXpl0it3r eXpl0it3r deleted the feature/system-handle branch Apr 22, 2016

@eXpl0it3r eXpl0it3r added this to Done in Android Backlog Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment