New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAL-soft for OS X to version 1.17.2 #1057

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
3 participants
@mantognini
Member

mantognini commented Feb 7, 2016

This PR attempts to fix #900 and #1000.

The first one seems to run fine on my machine. However, since I haven't yet upgraded my computer to 10.11, I can't test the second one. In any case, third party testing would be nice.

Note: it is known that OpenAL-soft might emit a warning regarding SSE on OS X 10.11 such as this one:

AL lib: (WW) UpdateDeviceParams: SSE performs best with multiple of 4 update sizes (1114)

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Feb 18, 2016

Member

So is this good to go? Can any other OS X user test this?

Member

eXpl0it3r commented Feb 18, 2016

So is this good to go? Can any other OS X user test this?

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Feb 19, 2016

Member

It was only partially tested. Regarding #1000, @willm127 did test this 10 days ago. Apart from a warning (kcat/openal-soft#32), it seemed fine.

But it remains to test whether #900 is fixed or not...

Member

mantognini commented Feb 19, 2016

It was only partially tested. Regarding #1000, @willm127 did test this 10 days ago. Apart from a warning (kcat/openal-soft#32), it seemed fine.

But it remains to test whether #900 is fixed or not...

@mantognini mantognini added s:accepted and removed s:undecided labels Apr 8, 2016

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Apr 8, 2016

Member

Due to the lack of testers on OS X, I move this PR to accepted and ready to be merged.

Member

mantognini commented Apr 8, 2016

Due to the lack of testers on OS X, I move this PR to accepted and ready to be merged.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 8, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Apr 8, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@Foaly

This comment has been minimized.

Show comment
Hide comment
@Foaly

Foaly Apr 9, 2016

Contributor

Wouldn't it be a good idea to update all OpenAL libraries to 1.17.2, not just on OSX? Looking through the changlog there are a few interesting things that everybody could benefit from. Mainly bugfixes (like UTF8 fixes for windows) or performance improvments using SSE extensions. There were also a whole range of effects added (Band pass Filters, Chorus, Flanger, Distortion, Equalizer, and Compressor) which could be interessting.

Contributor

Foaly commented Apr 9, 2016

Wouldn't it be a good idea to update all OpenAL libraries to 1.17.2, not just on OSX? Looking through the changlog there are a few interesting things that everybody could benefit from. Mainly bugfixes (like UTF8 fixes for windows) or performance improvments using SSE extensions. There were also a whole range of effects added (Band pass Filters, Chorus, Flanger, Distortion, Equalizer, and Compressor) which could be interessting.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Apr 9, 2016

Member

I'm not against it, but through a different PR.

Member

mantognini commented Apr 9, 2016

I'm not against it, but through a different PR.

@eXpl0it3r eXpl0it3r merged commit c98a84a into master Apr 14, 2016

16 checks passed

debian-gcc-64 Build #109 done.
Details
freebsd-gcc-64 Build #109 done.
Details
osx-clang-universal Build #113 done.
Details
static-analysis Build #109 done.
Details
windows-gcc-471-tdm-32 Build #112 done.
Details
windows-gcc-471-tdm-64 Build #112 done.
Details
windows-gcc-481-tdm-32 Build #112 done.
Details
windows-gcc-481-tdm-64 Build #112 done.
Details
windows-gcc-520-mingw-32 Build #110 done.
Details
windows-gcc-520-mingw-64 Build #112 done.
Details
windows-vc11-32 Build #111 done.
Details
windows-vc11-64 Build #112 done.
Details
windows-vc12-32 Build #111 done.
Details
windows-vc12-64 Build #110 done.
Details
windows-vc14-32 Build #110 done.
Details
windows-vc14-64 Build #112 done.
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/openal_osx branch Apr 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment