New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues reported by Coverity Scan static analysis #1064

Merged
merged 1 commit into from Mar 9, 2016

Conversation

Projects
None yet
3 participants
@binary1248
Member

binary1248 commented Feb 23, 2016

The issues that fall under the category "Insecure data handling" are all the result of the way sf::Packets function. Due to their nature (as for anything that relies on incoming network data), there is no way to make them "secure".

@binary1248 binary1248 added the bug label Feb 23, 2016

@binary1248 binary1248 self-assigned this Feb 23, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Feb 23, 2016

Member

Nicely done! 👍

Member

eXpl0it3r commented Feb 23, 2016

Nicely done! 👍

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Feb 24, 2016

Member

What's wrong with the std::ios stuff?

Member

LaurentGomila commented Feb 24, 2016

What's wrong with the std::ios stuff?

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Feb 24, 2016

Member

You don't restore stream precision after the first time you set it, meaning when you start playing the second sound, it only displays the duration using 2 instead of the full number of decimal places.

Member

binary1248 commented Feb 24, 2016

You don't restore stream precision after the first time you set it, meaning when you start playing the second sound, it only displays the duration using 2 instead of the full number of decimal places.

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Feb 24, 2016

Member

Then I'd rather add a call to std::setprecision where we need to restore the default precision, or remove all the iomanip calls. I like when examples focus on what they want to demonstrate, with as little clutter as possible around it.

Member

LaurentGomila commented Feb 24, 2016

Then I'd rather add a call to std::setprecision where we need to restore the default precision, or remove all the iomanip calls. I like when examples focus on what they want to demonstrate, with as little clutter as possible around it.

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Feb 24, 2016

Member

Done.

Member

binary1248 commented Feb 24, 2016

Done.

@eXpl0it3r eXpl0it3r added the s:accepted label Mar 3, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 3, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Mar 3, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r added this to the 2.4 milestone Mar 8, 2016

@eXpl0it3r eXpl0it3r merged commit 3ff1d25 into master Mar 9, 2016

16 checks passed

debian-gcc-64 Build #99 done.
Details
freebsd-gcc-64 Build #99 done.
Details
osx-clang-universal Build #99 done.
Details
static-analysis Build #99 done.
Details
windows-gcc-471-tdm-32 Build #102 done.
Details
windows-gcc-471-tdm-64 Build #102 done.
Details
windows-gcc-481-tdm-32 Build #102 done.
Details
windows-gcc-481-tdm-64 Build #102 done.
Details
windows-gcc-520-mingw-32 Build #100 done.
Details
windows-gcc-520-mingw-64 Build #102 done.
Details
windows-vc11-32 Build #101 done.
Details
windows-vc11-64 Build #102 done.
Details
windows-vc12-32 Build #101 done.
Details
windows-vc12-64 Build #100 done.
Details
windows-vc14-32 Build #100 done.
Details
windows-vc14-64 Build #102 done.
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/coverity_scan branch Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment