New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug where vorbis can't handle large buffers. #1067

Merged
merged 1 commit into from Apr 22, 2016

Conversation

Projects
None yet
5 participants
@eXpl0it3r
Member

eXpl0it3r commented Mar 6, 2016

This fixes the issue reported in this forum thread.

@eXpl0it3r eXpl0it3r self-assigned this Mar 6, 2016

@eXpl0it3r eXpl0it3r added this to the 2.4 milestone Mar 6, 2016

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Mar 6, 2016

Member

👍

Member

binary1248 commented Mar 6, 2016

👍

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Mar 6, 2016

Member

I can confirm both the bug and it fix. 👍

The PR's style however need a tiny bit of freshening:

  • missing space after for and while keywords
  • I would personally write static const int instead of const static int; I don't know if we decided anything on that, though.
Member

mantognini commented Mar 6, 2016

I can confirm both the bug and it fix. 👍

The PR's style however need a tiny bit of freshening:

  • missing space after for and while keywords
  • I would personally write static const int instead of const static int; I don't know if we decided anything on that, though.
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 6, 2016

Member

Added the spaces and since there are 3 occurrences of static const int and no occurrences of const static int I change it around as well.

Member

eXpl0it3r commented Mar 6, 2016

Added the spaces and since there are 3 occurrences of static const int and no occurrences of const static int I change it around as well.

@mantognini mantognini added s:accepted and removed s:undecided labels Mar 6, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 20, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Apr 20, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit 2c7b58f into master Apr 22, 2016

14 checks passed

debian-gcc-64 Build #117 done.
Details
freebsd-gcc-64 Build #117 done.
Details
osx-clang-universal Build #122 done.
Details
static-analysis Build #117 done.
Details
windows-gcc-492-tdm-32 Build #3 done.
Details
windows-gcc-492-tdm-64 Build #3 done.
Details
windows-gcc-530-mingw-32 Build #3 done.
Details
windows-gcc-530-mingw-64 Build #3 done.
Details
windows-vc11-32 Build #119 done.
Details
windows-vc11-64 Build #120 done.
Details
windows-vc12-32 Build #119 done.
Details
windows-vc12-64 Build #118 done.
Details
windows-vc14-32 Build #118 done.
Details
windows-vc14-64 Build #120 done.
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/ogg_writer_crash branch Apr 22, 2016

@jcowgill

This comment has been minimized.

Show comment
Hide comment
@jcowgill

jcowgill Apr 23, 2016

Contributor

@Dllieu What you wrote does something completely different (sample reading order).

Contributor

jcowgill commented on src/SFML/Audio/SoundFileWriterOgg.cpp in 2c7b58f Apr 23, 2016

@Dllieu What you wrote does something completely different (sample reading order).

This comment has been minimized.

Show comment
Hide comment
@Dllieu

Dllieu Apr 23, 2016

... my bad

Dllieu replied Apr 23, 2016

... my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment