New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing include <iterator> in String.inl #1068

Closed
wants to merge 186 commits into
base: bugfix/utf_iterators
from

Conversation

Projects
None yet
@Higestromm

Higestromm commented Mar 7, 2016

Bonjour,

Je suis passé aujourd'hui sous Visual c++ 2015 et j'ai un message d'erreur :

'back_inserter' : n'est pas membre de 'std' dans sfml-2.3.2\include\sfml\system\string.inl 31

ligne 31 on à ca :
template
String String::fromUtf8(T begin, T end)
{
String string;
Utf8::toUtf32(begin, end, std::back_inserter(string.m_string));
return string;
}

En cherchant un peu sur le net je suis tombé sur cette discutions :
http://stackoverflow.com/questions/2959234/vs2008-vs2010-leads-to-cryptic-stl-errors

Qui elle mène vers ça :
https://msdn.microsoft.com/en-us/library/bb531344.aspx

A priori, avec la dernière version de visual c++ il faudrait ajouter manuellement :

include

MarioLiebisch and others added some commits Dec 13, 2014

Added an .editorconfig file
This allows most IDEs and editors (with the proper plugin) to
automatically use the correct identation and line endings.

In short, you'll never ever have to worry about tabs or line breaks in your
code again. In additon, this won't have any effect on your other files or
projects, who'll continue to use your own global or custom settings.

There are plugins available for Microsoft Visual Studio, Notepad++, gedit, vim,
and many other popular editors and IDEs.

More information can be found on http://www.editorconfig.org/.
Add linguist-vendored attribute to the extlibs directory to prevent G…
…itHub from factoring in dependencies when determining the primary language of the repository.
Fixed missing pthread dependency
The find script fails to add pthread to the SFML_SYSTEM_DEPENDENCIES when linking SFML statically on Linux.
Relaxed cmake installation rules regarding OS X framework dependencies
No longer install sndfile and/or freetype frameworks if SFML is built libraries not from the extlibs folder.
Related to #620 and Homebrew/legacy-homebrew#35479

Xcode templates are not updated yet to reflect that change since it involve toying with `install_name_tool` and is quite complex.
Fixed an issue in InputImpl::getSFOpenGLViewFromSFMLWindow failing to…
… retrieve the SFOpenGLView from the contentview's subview when using fullscreen (see issue #782).
Android: Updated the toolchain file and CMake scripts
* Replaced the toolchain file with a new version based on [zuhowei's fork](https://github.com/zhuowei/android-cmake), which enables x64 builds as well as support for the latest NDK. This breaks compatibility with old build directories.
* Removed the STL dependency from **sfml-activity** rather than relying on *some* implementation implicitly linked by default.
* Deleted *project.properties*, which wasn't supposed to be part of the repository code. You have to use the Android SDK to recreate it (`android update project --path to/your/example --target 1 --name SFML-Example`).
* Made it possible to select a STL implementation to be used (default: `c++_shared`). Keep in mind that not all available configurations are necessarily compatible with SFML.
* Fixed linker flags to be compatible with Nvidia's Nsight Tegra for Visual Studio.
* It is now possible to compile the Android version using Nvidia's Nsight Tegra for Visual Studio (requires up-to-date CMake and `CMAKE_SFML_SYSTEM` to be set to `Android`; keep in mind that this is still experimental and requires further CMake updates).
* Updated and renamed some Android specific CMake variables.
* Made `armeabi-v7a` the default ABI for Android builds.
Updated Xcode templates
- The installation paths are no longer hard coded; cmake now configures them so that Frameworks and libs can be installed somewhere else.
- No longer copy sndfile.framework but instead copy the new dependencies of the audio module.
- No longer copy .DS_Store to the install directory.
Added OS X frameworks: ogg, vorbis, vorbisfile, vorbisenc and flac
 - Updated CMake installation script
 - The build script for the frameworks is available here: https://gist.github.com/mantognini/05460d9b6a8a272ed188

mantognini and others added some commits Oct 30, 2015

Rewrite RenderWindow::capture to make use of a single texture transfe…
…r instead of transferring each row of the framebuffer individually.
Made WAV file reader no longer assume that data chunk goes till end
of file to prevent reading trailing metadata as samples.
Fixed seeking in multi channel FLAC files.
Updated seek() documentation.
@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Mar 7, 2016

Member

Hi!

Merci de communiquer en anglais ici de sorte que toute l'équipe et la communauté puisse participer aux discussions. Merci aussi de lire les règles de contribution.

I've no idea why you create a PR from that branch... Nor why parts of your description are obviously missing.

I gather you meant to say that #include <iterator> was missing from https://github.com/SFML/SFML/blob/master/include/SFML/System/String.inl, which is indeed correct. I'll deal with it.

Member

mantognini commented Mar 7, 2016

Hi!

Merci de communiquer en anglais ici de sorte que toute l'équipe et la communauté puisse participer aux discussions. Merci aussi de lire les règles de contribution.

I've no idea why you create a PR from that branch... Nor why parts of your description are obviously missing.

I gather you meant to say that #include <iterator> was missing from https://github.com/SFML/SFML/blob/master/include/SFML/System/String.inl, which is indeed correct. I'll deal with it.

@mantognini mantognini closed this Mar 7, 2016

@mantognini mantognini changed the title from Visual c++ 2015 to Missing include <iterator> in String.inl Mar 7, 2016

@ekunuke

This comment has been minimized.

Show comment
Hide comment
@ekunuke

ekunuke Apr 5, 2016

I believe this commit introduces an infinite loop when trying to create an internalContext.

The loop I'm encountering looks something like:

  • GlContext::ensureContext()
  • getInternalContext()
  • sf::Context::Context()
  • GlResource()
  • GlContext::ensureContext()

ekunuke commented on src/SFML/Window/GlContext.cpp in 2752bbc Apr 5, 2016

I believe this commit introduces an infinite loop when trying to create an internalContext.

The loop I'm encountering looks something like:

  • GlContext::ensureContext()
  • getInternalContext()
  • sf::Context::Context()
  • GlResource()
  • GlContext::ensureContext()

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 5, 2016

Member

It has already been addressed in this PR.. There are also multiple threads on the forum. 😉

Member

eXpl0it3r replied Apr 5, 2016

It has already been addressed in this PR.. There are also multiple threads on the forum. 😉

This comment has been minimized.

Show comment
Hide comment
@ekunuke

ekunuke Apr 5, 2016

Thanks, I guess I didn't look hard enough before posting. Apologies :)

ekunuke replied Apr 5, 2016

Thanks, I guess I didn't look hard enough before posting. Apologies :)

@gjorando

This comment has been minimized.

Show comment
Hide comment
@gjorando

gjorando May 7, 2016

I think I got the fix for my issue (Arch Linux reporting my app isn't responding), thank you!

gjorando commented on 94dd1d7 May 7, 2016

I think I got the fix for my issue (Arch Linux reporting my app isn't responding), thank you!

@mantognini mantognini added this to the 2.4 milestone Aug 5, 2016

@mantognini mantognini self-assigned this Aug 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment