New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed not being able to set the window icon properly on some Unix window managers #1088

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@binary1248
Member

binary1248 commented May 10, 2016

Fixes #1087.

Also added support for setting the window icon via ICCCM (_NET_WM_ICON) which provides a higher quality icon in window managers that support icon alpha blending.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 10, 2016

Member

Looks like this got somehow lost, can you rebase this @binary1248?

Member

eXpl0it3r commented Aug 10, 2016

Looks like this got somehow lost, can you rebase this @binary1248?

Fixed not being able to set the window icon properly on some Unix win…
…dow managers (#1087) and added support for setting the window icon via ICCCM (_NET_WM_ICON).
@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Aug 10, 2016

Member

Done.

Member

binary1248 commented Aug 10, 2016

Done.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 10, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Aug 10, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 13, 2016

Member

Merged in 20c2d8d on the 2.4.x branch (thanks GitHub for still not letting us retarget PRs...)

Member

eXpl0it3r commented Aug 13, 2016

Merged in 20c2d8d on the 2.4.x branch (thanks GitHub for still not letting us retarget PRs...)

@eXpl0it3r eXpl0it3r closed this Aug 13, 2016

@eXpl0it3r eXpl0it3r deleted the bugfix/unix_window_icon branch Aug 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment