New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Readded support for libc++ and use it as the standard STL #1116

Merged
merged 1 commit into from Aug 5, 2016

Conversation

4 participants
@MarioLiebisch
Member

MarioLiebisch commented Jul 23, 2016

Didn't care about the initial removal of libc++ since stlport worked fine for me, but it's obviously causing C++11 trouble as discussed here.

Clear case of "revert it, even though it's working". :)

@MarioLiebisch MarioLiebisch added this to the 2.4 milestone Jul 23, 2016

@MarioLiebisch MarioLiebisch self-assigned this Jul 23, 2016

@texus

This comment has been minimized.

Show comment
Hide comment
@texus

texus Jul 23, 2016

Contributor

I can confirm that both c++_shared and c++_static options work again now.

Looking at the diff with the old version it looks like these two lines of documentation are still missing though.

Contributor

texus commented Jul 23, 2016

I can confirm that both c++_shared and c++_static options work again now.

Looking at the diff with the old version it looks like these two lines of documentation are still missing though.

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Jul 23, 2016

Member

You're right, they're back.

Member

MarioLiebisch commented Jul 23, 2016

You're right, they're back.

@victorlevasseur

This comment has been minimized.

Show comment
Hide comment
@victorlevasseur

victorlevasseur Jul 30, 2016

Contributor

It works again. Unfortunately, I can't test my app with this and r12b because of a bug in the lastest Android NDK.

Contributor

victorlevasseur commented Jul 30, 2016

It works again. Unfortunately, I can't test my app with this and r12b because of a bug in the lastest Android NDK.

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Jul 30, 2016

Member

Care to elaborate? I'm using 12b myself without issues.

Member

MarioLiebisch commented Jul 30, 2016

Care to elaborate? I'm using 12b myself without issues.

@victorlevasseur

This comment has been minimized.

Show comment
Hide comment
@victorlevasseur

victorlevasseur Jul 30, 2016

Contributor

Don't worry, it's a bug on their side that happens when catching std::bad_cast (they told me that the bug has been fixed for the next version)

Contributor

victorlevasseur commented Jul 30, 2016

Don't worry, it's a bug on their side that happens when catching std::bad_cast (they told me that the bug has been fixed for the next version)

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 2, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Aug 2, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit 3a2e176 into master Aug 5, 2016

14 checks passed

debian-gcc-64 Build #169 done.
Details
freebsd-gcc-64 Build #169 done.
Details
osx-clang-el-capitan Build #49 done.
Details
static-analysis Build #169 done.
Details
windows-gcc-492-tdm-32 Build #54 done.
Details
windows-gcc-492-tdm-64 Build #54 done.
Details
windows-gcc-530-mingw-32 Build #54 done.
Details
windows-gcc-530-mingw-64 Build #54 done.
Details
windows-vc11-32 Build #170 done.
Details
windows-vc11-64 Build #170 done.
Details
windows-vc12-32 Build #170 done.
Details
windows-vc12-64 Build #168 done.
Details
windows-vc14-32 Build #169 done.
Details
windows-vc14-64 Build #171 done.
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/android-libc++ branch Aug 5, 2016

@eXpl0it3r eXpl0it3r added this to Backlog in Android Backlog Jan 25, 2018

@eXpl0it3r eXpl0it3r moved this from Backlog to Done in Android Backlog Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment