New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define SFML_OS_FREEBSD when compiling for kFreeBSD #1129

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jcowgill
Contributor

jcowgill commented Aug 11, 2016

As a result of pull request #1102, SFML lost the ability to compile on Debian's kFreeBSD architecture. On this architecture, CMAKE_SYSTEM_NAME is "kFreeBSD" because it isn't a real FreeBSD system (only the kernel is from FreeBSD).

This PR converts the FreeBSD check in Config.cmake back to a more restrictive MATCHES if statement.

Failing build log for reference:
https://buildd.debian.org/status/fetch.php?pkg=libsfml&arch=kfreebsd-amd64&ver=2.4.0%2Bdfsg-1&stamp=1470919689

@eXpl0it3r eXpl0it3r added this to the 2.4.1 milestone Aug 11, 2016

@eXpl0it3r eXpl0it3r self-assigned this Aug 11, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 11, 2016

Member

Thanks for the reporting it and providing a fix!

Member

eXpl0it3r commented Aug 11, 2016

Thanks for the reporting it and providing a fix!

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 13, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Aug 13, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 15, 2016

Member

Merged in e0f369c on the 2.4.x branch.

Member

eXpl0it3r commented Aug 15, 2016

Merged in e0f369c on the 2.4.x branch.

@eXpl0it3r eXpl0it3r closed this Aug 15, 2016

@jcowgill jcowgill deleted the jcowgill:kfreebsd-config branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment