Define SFML_OS_FREEBSD when compiling for kFreeBSD #1129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the reporting it and providing a fix! |
|
This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns. |
|
Merged in e0f369c on the 2.4.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As a result of pull request #1102, SFML lost the ability to compile on Debian's kFreeBSD architecture. On this architecture,
CMAKE_SYSTEM_NAMEis "kFreeBSD" because it isn't a real FreeBSD system (only the kernel is from FreeBSD).This PR converts the FreeBSD check in Config.cmake back to a more restrictive MATCHES if statement.
Failing build log for reference:
https://buildd.debian.org/status/fetch.php?pkg=libsfml&arch=kfreebsd-amd64&ver=2.4.0%2Bdfsg-1&stamp=1470919689