New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed uniform error message #1131

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Hapaxia
Contributor

Hapaxia commented Aug 13, 2016

Changed the error message for using uniforms to use the word uniform instead of the word parameter since parameter's deprecation.

A minor text output alteration to keep consistency for the new interface.

Changed uniform error message
Changed the error message for using uniforms to use the word uniform instead of the word parameter since parameter's deprecation.

A minor text output alteration to keep consistent with the new interface.
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 13, 2016

Member

Looks good to me!

Member

eXpl0it3r commented Aug 13, 2016

Looks good to me!

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Aug 13, 2016

Member

👍

Member

binary1248 commented Aug 13, 2016

👍

@eXpl0it3r eXpl0it3r added s:accepted and removed s:undecided labels Aug 13, 2016

@eXpl0it3r eXpl0it3r self-assigned this Aug 13, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 13, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Aug 13, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 15, 2016

Member

Merged in 23d6bb5 on the 2.4.x branch.

Member

eXpl0it3r commented Aug 15, 2016

Merged in 23d6bb5 on the 2.4.x branch.

@eXpl0it3r eXpl0it3r closed this Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment