New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sf::Window documentation #1133

Closed
wants to merge 1 commit into
base: 2.4.x
from

Conversation

Projects
None yet
3 participants
@Hapaxia
Contributor

Hapaxia commented Aug 16, 2016

removed part of the sentence that stated that cursor grabbing is different for fullscreen windows as this is not the case.

as mentioned here:
http://en.sfml-dev.org/forums/index.php?topic=20671.msg148597#msg148597

update Window documentation
removed part of the sentence that stated that cursor grabbing is different for fullscreen windows as this is not the case.

@Hapaxia Hapaxia changed the title from update sf::Window documentation to Updates sf::Window documentation Aug 18, 2016

@Hapaxia Hapaxia changed the title from Updates sf::Window documentation to Updated sf::Window documentation Aug 18, 2016

@mantognini mantognini added this to the 2.4.1 milestone Aug 18, 2016

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Aug 18, 2016

Member

I put the undecided tag because I forgot what happens on OS X right now. Someone with a dual monitor setup and OS X should test this, and maybe open another issue for that.

Member

mantognini commented Aug 18, 2016

I put the undecided tag because I forgot what happens on OS X right now. Someone with a dual monitor setup and OS X should test this, and maybe open another issue for that.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 12, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Sep 12, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r added s:accepted and removed s:undecided labels Sep 12, 2016

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 12, 2016

Member

Wait one or two more days, just so I can double check the behaviour on OS X. If it's closed I fear I'll forget about it. ;)

Member

mantognini commented Sep 12, 2016

Wait one or two more days, just so I can double check the behaviour on OS X. If it's closed I fear I'll forget about it. ;)

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 12, 2016

Member

Luckily, I was able to find a second monitor. Bad news is that OS X strictly follows the doc, meaning that the cursor is always grabbed when in fullscreen mode.

This PR can be merged now, I'll open an issue for OS X.

Member

mantognini commented Sep 12, 2016

Luckily, I was able to find a second monitor. Bad news is that OS X strictly follows the doc, meaning that the cursor is always grabbed when in fullscreen mode.

This PR can be merged now, I'll open an issue for OS X.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 12, 2016

Member

Bad news

Why bad news? 😲

This PR can be merged now

👍

Member

eXpl0it3r commented Sep 12, 2016

Bad news

Why bad news? 😲

This PR can be merged now

👍

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 12, 2016

Member

Why bad news?

More work for (probably) me... =P

Member

mantognini commented Sep 12, 2016

Why bad news?

More work for (probably) me... =P

@eXpl0it3r eXpl0it3r self-assigned this Sep 13, 2016

@eXpl0it3r eXpl0it3r changed the base branch from master to 2.4.x Sep 13, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 13, 2016

Member

Merged with e849166 onto the 2.4.x branch.

Member

eXpl0it3r commented Sep 13, 2016

Merged with e849166 onto the 2.4.x branch.

@eXpl0it3r eXpl0it3r closed this Sep 13, 2016

mantognini added a commit that referenced this pull request Sep 16, 2016

eXpl0it3r added a commit that referenced this pull request Sep 29, 2016

eXpl0it3r added a commit that referenced this pull request Oct 1, 2016

jmcmorris pushed a commit to jmcmorris/SFML that referenced this pull request Jan 3, 2017

iamPHEN added a commit to Bablawn3d5/SFML that referenced this pull request Mar 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment