New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed possible hang when setting visibility if external window source… #1136

Merged
merged 1 commit into from Aug 23, 2016

Conversation

Projects
None yet
2 participants
@binary1248
Member

binary1248 commented Aug 21, 2016

Some window sources e.g. Qt don't bother to forward all events to us. This breaks the assumption that we will eventually get a VisibilityNotify event when we set the window's visibility ourselves. This fix disables tracking the mapping state of the window if it comes from an external source since they are the ones who should take care of mapping and visibility state.

See: http://en.sfml-dev.org/forums/index.php?topic=20725.0

@binary1248 binary1248 self-assigned this Aug 21, 2016

@eXpl0it3r eXpl0it3r added this to the 2.4.1 milestone Aug 21, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 21, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Aug 21, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Fixed possible hang when setting visibility if external window source…
…s e.g. Qt don't forward visibility notify events to us.

@eXpl0it3r eXpl0it3r merged commit 34efedd into 2.4.x Aug 23, 2016

14 checks passed

debian-gcc-64 Build #196 done.
Details
freebsd-gcc-64 Build #196 done.
Details
osx-clang-el-capitan Build #77 done.
Details
static-analysis Build #196 done.
Details
windows-gcc-492-tdm-32 Build #81 done.
Details
windows-gcc-492-tdm-64 Build #81 done.
Details
windows-gcc-610-mingw-32 Build #15 done.
Details
windows-gcc-610-mingw-64 Build #15 done.
Details
windows-vc11-32 Build #197 done.
Details
windows-vc11-64 Build #197 done.
Details
windows-vc12-32 Build #197 done.
Details
windows-vc12-64 Build #195 done.
Details
windows-vc14-32 Build #196 done.
Details
windows-vc14-64 Build #198 done.
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/unix_visibility branch Aug 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment