New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some simple messaging when trying to build under Cygwin #1153

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
4 participants
@MarioLiebisch
Member

MarioLiebisch commented Sep 22, 2016

While this doesn't change anything directly, it makes it more clear why CMake is actually failing and prevents situations such as the one described here.

@MarioLiebisch MarioLiebisch added this to the 2.4.1 milestone Sep 22, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 22, 2016

Member

Last time we bumped the CMake version, we had to make surr that popular Linux distroa such as Debian (stable) or Ubuntu supported the minimum requirement. Did you check that as well?

Member

eXpl0it3r commented Sep 22, 2016

Last time we bumped the CMake version, we had to make surr that popular Linux distroa such as Debian (stable) or Ubuntu supported the minimum requirement. Did you check that as well?

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Sep 22, 2016

Member

Nope, but if 5 years could still be too early, we can just go the easy way and suppress the warning with a variable. :)

Member

MarioLiebisch commented Sep 22, 2016

Nope, but if 5 years could still be too early, we can just go the easy way and suppress the warning with a variable. :)

@jantzeno

This comment has been minimized.

Show comment
Hide comment
@jantzeno

jantzeno Sep 22, 2016

Ubuntu 14.04 LTS Trusty (also Windows 10 base) - 2.8.12.2
http://packages.ubuntu.com/trusty/cmake

Ubuntu 16.04 LTS Xenia - 3.5.1
http://packages.ubuntu.com/xenial/cmake

Debian 8 Jessie - 3.0.2
https://packages.debian.org/jessie/cmake

Debian 7 Wheezy - 2.8.9
https://packages.debian.org/source/wheezy/cmake

Fedora 23-24 >= 3.4.3
https://apps.fedoraproject.org/packages/cmake

jantzeno commented Sep 22, 2016

Ubuntu 14.04 LTS Trusty (also Windows 10 base) - 2.8.12.2
http://packages.ubuntu.com/trusty/cmake

Ubuntu 16.04 LTS Xenia - 3.5.1
http://packages.ubuntu.com/xenial/cmake

Debian 8 Jessie - 3.0.2
https://packages.debian.org/jessie/cmake

Debian 7 Wheezy - 2.8.9
https://packages.debian.org/source/wheezy/cmake

Fedora 23-24 >= 3.4.3
https://apps.fedoraproject.org/packages/cmake

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 22, 2016

Member

Thanks @jantzeno for that info!

Member

eXpl0it3r commented Sep 22, 2016

Thanks @jantzeno for that info!

@@ -64,6 +64,10 @@ elseif(${CMAKE_SYSTEM_NAME} STREQUAL "Android")
# use the OpenGL ES implementation on Android
set(OPENGL_ES 1)
# comparing CMAKE_SYSTEM_NAME with "CYGWIN" generates a false warning depending on the CMake version
# let's avoid it so the actual error is more visible
elseif(${CYGWIN})

This comment has been minimized.

@eXpl0it3r

eXpl0it3r Sep 29, 2016

Member

Is ${CYGWIN} automatically defined when using CYGWIN?

@eXpl0it3r

eXpl0it3r Sep 29, 2016

Member

Is ${CYGWIN} automatically defined when using CYGWIN?

This comment has been minimized.

@MarioLiebisch

MarioLiebisch Sep 29, 2016

Member

Yes, it's Cygwin's equivalent of WIN32.

@MarioLiebisch

MarioLiebisch Sep 29, 2016

Member

Yes, it's Cygwin's equivalent of WIN32.

@@ -13,6 +13,9 @@ endmacro()
# determine whether to create a debug or release build
sfml_set_option(CMAKE_BUILD_TYPE Release STRING "Choose the type of build (Debug or Release)")
# Suppress Cygwin legacy warning
set(CMAKE_LEGACY_CYGWIN_WIN32 0)

This comment has been minimized.

@eXpl0it3r

eXpl0it3r Sep 29, 2016

Member

What warning was that?

@eXpl0it3r

eXpl0it3r Sep 29, 2016

Member

What warning was that?

This comment has been minimized.

@MarioLiebisch

MarioLiebisch Sep 29, 2016

Member

Legacy behavior defined WIN32 for Cygwin builds, the warning notifies you about that (it's removed in 2.8.4).

@MarioLiebisch

MarioLiebisch Sep 29, 2016

Member

Legacy behavior defined WIN32 for Cygwin builds, the warning notifies you about that (it's removed in 2.8.4).

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 1, 2016

Member

Wanted to test this with Cygwin, but now their website is down...

Seems to work fine, but as I said in the comment "Use MinGW instead" might be misleading since you can install MinGW through Cygwin.

Member

eXpl0it3r commented Oct 1, 2016

Wanted to test this with Cygwin, but now their website is down...

Seems to work fine, but as I said in the comment "Use MinGW instead" might be misleading since you can install MinGW through Cygwin.

@eXpl0it3r eXpl0it3r self-assigned this Oct 4, 2016

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 4, 2016

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Oct 4, 2016

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit 3da7181 into 2.4.x Oct 4, 2016

15 checks passed

android-armeabi-v7a-api13 Build #7 done.
Details
debian-gcc-64 Build #281 done.
Details
freebsd-gcc-64 Build #244 done.
Details
osx-clang-el-capitan Build #126 done.
Details
static-analysis Build #251 done.
Details
windows-gcc-492-tdm-32 Build #127 done.
Details
windows-gcc-492-tdm-64 Build #127 done.
Details
windows-gcc-610-mingw-32 Build #62 done.
Details
windows-gcc-610-mingw-64 Build #62 done.
Details
windows-vc11-32 Build #243 done.
Details
windows-vc11-64 Build #243 done.
Details
windows-vc12-32 Build #242 done.
Details
windows-vc12-64 Build #241 done.
Details
windows-vc14-32 Build #242 done.
Details
windows-vc14-64 Build #245 done.
Details

@eXpl0it3r eXpl0it3r added the s:accepted label Oct 4, 2016

@eXpl0it3r eXpl0it3r deleted the bugfix/cygwin-exclusion branch Oct 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment