New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced TransientContextLock implementation with a more elaborate one #1172

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
3 participants
@binary1248
Member

binary1248 commented Nov 27, 2016

Fixes #1165.

@BlueCobold

This comment has been minimized.

Show comment
Hide comment
@BlueCobold

BlueCobold Dec 12, 2016

Contributor

Issue not fixed with this branch. Getting same errors as reported here:
http://en.sfml-dev.org/forums/index.php?topic=21102.msg151328
The only difference is, that the RenderWindow now opens whereas it didn't before at all.

When using the master and simply changing "NULL" to "currentContext", the issue is gone. Not my idea, just read it somewhere. Dunno how much sense this solution actually makes.

Contributor

BlueCobold commented Dec 12, 2016

Issue not fixed with this branch. Getting same errors as reported here:
http://en.sfml-dev.org/forums/index.php?topic=21102.msg151328
The only difference is, that the RenderWindow now opens whereas it didn't before at all.

When using the master and simply changing "NULL" to "currentContext", the issue is gone. Not my idea, just read it somewhere. Dunno how much sense this solution actually makes.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jan 5, 2017

Member

Should we go ahead and merge this, even if the fix for the half a decade old driver doesn't seem to work after all, @binary1248?

Member

eXpl0it3r commented Jan 5, 2017

Should we go ahead and merge this, even if the fix for the half a decade old driver doesn't seem to work after all, @binary1248?

@BlueCobold

This comment has been minimized.

Show comment
Hide comment
@BlueCobold

BlueCobold Jan 5, 2017

Contributor

What purpose would this PR serve if it doesn't fix what it was intended to fix?

Contributor

BlueCobold commented Jan 5, 2017

What purpose would this PR serve if it doesn't fix what it was intended to fix?

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jan 5, 2017

Member

It fixed some other issue. See the reference above and the first commit.

Member

eXpl0it3r commented Jan 5, 2017

It fixed some other issue. See the reference above and the first commit.

Replaced TransientContextLock implementation with a more elaborate on…
…e which relies on locking a single mutex and thus avoids lock order inversion. Fixes #1165.
@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Jan 25, 2017

Member

Split second commit into a separate PR under #1186 and rebased this PR onto 2.4.x.

Member

binary1248 commented Jan 25, 2017

Split second commit into a separate PR under #1186 and rebased this PR onto 2.4.x.

@eXpl0it3r

As little as I understand of all of it, this seems good.

@eXpl0it3r eXpl0it3r merged commit 2857207 into 2.4.x Jan 27, 2017

15 checks passed

android-armeabi-v7a-api13 Build #73 done.
Details
debian-gcc-64 Build #346 done.
Details
freebsd-gcc-64 Build #308 done.
Details
osx-clang-el-capitan Build #193 done.
Details
static-analysis Build #315 done.
Details
windows-gcc-492-tdm-32 Build #206 done.
Details
windows-gcc-492-tdm-64 Build #203 done.
Details
windows-gcc-610-mingw-32 Build #138 done.
Details
windows-gcc-610-mingw-64 Build #140 done.
Details
windows-vc11-32 Build #317 done.
Details
windows-vc11-64 Build #315 done.
Details
windows-vc12-32 Build #315 done.
Details
windows-vc12-64 Build #314 done.
Details
windows-vc14-32 Build #317 done.
Details
windows-vc14-64 Build #318 done.
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/transient_context branch Jan 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment