Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix for static builds with mingw-w64 compilers #218

Merged
merged 2 commits into from Feb 17, 2013

Conversation

Projects
None yet
3 participants
Contributor

BMBurstein commented May 1, 2012

Fix for issue #132

@BMBurstein BMBurstein closed this May 1, 2012

@BMBurstein BMBurstein reopened this May 1, 2012

Owner

eXpl0it3r commented Jan 7, 2013

Would be nice if the patch gets applied, otherwise one always needs to hack the macros to get it working...

Additionally it could also get prevented/fixed by correctly linking the dependencies.

Owner

LaurentGomila commented Jan 7, 2013

There's no point fixing this if there's no 64-bit version of the external dependencies.

Owner

eXpl0it3r commented Jan 7, 2013

The MinGW-w64 project doesn't provide only a 64bit compiler, but they also provide a 32bit compiler, which has the same problem (e.g. see my Nightly Builds).
For the 32bit MinGW-w64 branch I'd have to change the path to ${STANDARD_LIBS_PATH}/i686-w64-mingw32/lib/lib${lib}.a.

Owner

LaurentGomila commented Jan 8, 2013

I see.

Owner

eXpl0it3r commented Feb 17, 2013

I've just tested this pull request and it works for all the tested compilers and see no reason for it not to work on possibly others.
I've tested the following compilers:

  • Official MinGW32, just to see that nothing breaks.
  • Visual Studio 2010, just to see that nothing breaks.
  • MinGW-w64 x86 compiler by rubenvb
  • MinGW-w64 x64 compiler by rubenvb
  • MinGW-w64 x64 TDM

Would be nice, if this could finally get integrated!

LaurentGomila added a commit that referenced this pull request Feb 17, 2013

Merge pull request #218 from BMBurstein/master
fix for static builds with mingw-w64 compilers

@LaurentGomila LaurentGomila merged commit 274d316 into SFML:master Feb 17, 2013

Owner

LaurentGomila commented Feb 17, 2013

Thanks for testing it!

I merge the modifications, but the 64-bit dependencies are still missing ;)

@ghost ghost assigned LaurentGomila Feb 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment