New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update src/SFML/Network/TcpSocket.cpp #221

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@JoshuaFlynn

JoshuaFlynn commented May 6, 2012

Modified it so that, when connection succeeds the first time, it sets the blocking state back to what it was (otherwise a blocking socket, on the first successful connection, would turn into a non-blocking one).

@JoshuaFlynn

This comment has been minimized.

Show comment
Hide comment
@JoshuaFlynn

JoshuaFlynn May 6, 2012

Also, I have no idea how GitHub works so apologies if I happen to break something.

JoshuaFlynn commented May 6, 2012

Also, I have no idea how GitHub works so apologies if I happen to break something.

@nitrix

This comment has been minimized.

Show comment
Hide comment
@nitrix

nitrix May 7, 2012

No worries, you're doing it right; Laurent will look into it.

nitrix commented May 7, 2012

No worries, you're doing it right; Laurent will look into it.

@ghost ghost assigned LaurentGomila Jul 30, 2013

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Aug 9, 2013

Member

Change applied manually. Thanks for your help :)

Member

LaurentGomila commented Aug 9, 2013

Change applied manually. Thanks for your help :)

LaurentGomila added a commit that referenced this pull request Aug 12, 2013

Fixed TcpSocket::connect with timeout could switch a blocking socket …
…to non-blocking mode on immediate connection success (#221)

@eXpl0it3r eXpl0it3r added s:superseded and removed s:superseded labels Jul 4, 2014

jcowgill added a commit to jcowgill/SFML that referenced this pull request Sep 22, 2014

Fixed TcpSocket::connect with timeout could switch a blocking socket …
…to non-blocking mode on immediate connection success (SFML#221)

(cherry picked from commit 5624948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment