New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sf::String
in terms of std::u32string
#2480
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2480 +/- ##
==========================================
- Coverage 25.84% 24.03% -1.81%
==========================================
Files 226 226
Lines 19419 19405 -14
Branches 4714 4714
==========================================
- Hits 5018 4664 -354
- Misses 13868 14259 +391
+ Partials 533 482 -51
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Mostly good, 2 minor comments 🙂
95c3470
to
8694ff2
Compare
Generally looks good to me, I'm in favour of this PR. |
e5fcb91
to
66c70af
Compare
Description
Closes #2470
This will make it easier to do things like use UTF-32 string literals since
sf::String
will have a constructor that perfectly matches that type.