Remove default empty state of sf::FileInputStream#3088
Merged
ChrisThrasher merged 1 commit intomasterfrom Jun 11, 2024
Merged
Conversation
ChrisThrasher
commented
Jun 10, 2024
ChrisThrasher
force-pushed
the
optional_file_input_stream
branch
from
defc5c1 to
e381bff
Compare
vittorioromeo
requested changes
Jun 10, 2024
Member
vittorioromeo
left a comment
vittorioromeo
left a comment
There was a problem hiding this comment.
Nice work as usual! I do want to see the private constructor pattern we've used before applied here as well, I wrote some code as a review comment and I don't think it's too bad.
This comment was marked as outdated.
This comment was marked as outdated.
ChrisThrasher
force-pushed
the
optional_file_input_stream
branch
from
e381bff to
0a6163c
Compare
ChrisThrasher
force-pushed
the
optional_file_input_stream
branch
from
0a6163c to
788b938
Compare
Collaborator
Pull Request Test Coverage Report for Build 9459225139Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuing in the tradition of
sf::Event#2992sf::Font#3020sf::Image#3021sf::SoundBuffer#3022sf::Shader#3025sf::Cursor#3028sf::InputSoundFileandsf::OutputSoundFile#3030sf::RenderTexture#3032sf::Texture#3027sf::Music#3075sf::MemoryInputStream#3085Was it necessary that I list out all of these PRs? No. But I thought it would be fun to include a really long list of PRs that this one refers to. Look how satisfying all these matching PR titles are.