New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applied audiobuffer reload fix. #367

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@kd7tck
Contributor

kd7tck commented Mar 15, 2013

Review please for errors. I have never done a pull request before on github, hope I didn't mess anything up.

@kd7tck

This comment has been minimized.

Show comment
Hide comment
@kd7tck

kd7tck Mar 15, 2013

Contributor

This is for #354.

Contributor

kd7tck commented Mar 15, 2013

This is for #354.

@Foaly

This comment has been minimized.

Show comment
Hide comment
@Foaly

Foaly Mar 16, 2013

Contributor

Looks good!

Contributor

Foaly commented Mar 16, 2013

Looks good!

@Foaly

This comment has been minimized.

Show comment
Hide comment
@Foaly

Foaly May 9, 2013

Contributor

Since SFML 2.0 is released and this bug still persists, wouldn't it be good to merge this pull request?

Contributor

Foaly commented May 9, 2013

Since SFML 2.0 is released and this bug still persists, wouldn't it be good to merge this pull request?

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila May 9, 2013

Member

Yes.

Style issue: the /// \return Void doxygen comment should be removed.

Question: why do you delete the OpenAL buffer and generate a new one? Can't you reuse the existing one? In this case, you can refactor code and call unload() in the destructor.

Member

LaurentGomila commented May 9, 2013

Yes.

Style issue: the /// \return Void doxygen comment should be removed.

Question: why do you delete the OpenAL buffer and generate a new one? Can't you reuse the existing one? In this case, you can refactor code and call unload() in the destructor.

@kd7tck kd7tck closed this May 9, 2013

@eXpl0it3r eXpl0it3r added this to the 2.2 milestone Jul 7, 2014

@eXpl0it3r eXpl0it3r added bug labels Jul 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment