Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for geometry shaders (implements #428) #432

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
6 participants
@Mrowqa
Copy link
Contributor

commented Jul 18, 2013

I need geometry shaders, so I implemented support for them. API looks like that described in my ticket. It's clean and tested commit. I corrected documentation, too.

@michalivne

This comment has been minimized.

Copy link

commented May 14, 2014

Hi,

Great job mate! How can I use the added support of Geometry shaders? Is it available in the developers version?

@MarioLiebisch

This comment has been minimized.

Copy link
Member

commented May 14, 2014

@michalivne You'll have to wait for it to be merged or pull from Mrowga:master.

If you're using the command line version of git, you should be able to do something like this:

git remote add mrowqa https://github.com/Mrowqa/SFML.git
git pull mrowga master

Keep in mind that this won't necessarily work out of the box and you might have to fix some conflicts (due to code updates in the official version).

Edit: Tried it and you'll have only one minor conflict while merging.

@MarioLiebisch

This comment has been minimized.

Copy link
Member

commented May 14, 2014

@Mrowqa If you don't object to it, I might be going to pick this up, rebase the patch, add an example (since geometry shaders aren't that obvious IMO) and create another pull request either for SFML or your fork.

@michalivne

This comment has been minimized.

Copy link

commented May 14, 2014

@MarioLiebisch That would be great!

@Mrowqa

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2014

Sorry for not responding for a long time - I rarely log in github. I'm very glad that my effort was helpful for someone and thank you, @MarioLiebisch, for taking up this pull request and improving it.

@binary1248

This comment has been minimized.

Copy link
Member

commented Jul 13, 2014

Since this pull request has been taken over by @MarioLiebisch in #599, I think we can mark this as superseded. Don't worry, you will still get credit for the first commit that the new pull request is based on 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.