New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for VS 2013 and TDM compilers. #482

Merged
merged 1 commit into from Oct 15, 2013

Conversation

Projects
None yet
3 participants
@eXpl0it3r
Member

eXpl0it3r commented Oct 15, 2013

Clean commit instead of #481 ...

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Oct 15, 2013

Member

Thanks for this new PR.

Well don't you want to change to the VS version then, since you're already using that in the macro as well.
So it would be 2005, 2008, 2010, 2012, 2013. It at least would be easier to fix.

I would really prefer MSVC version. This stuff is about the compiler, not the IDE. And maybe some day we'll see multiple versions of the compiler supported by the same version of the IDE (this was already more or less the case with VS 2012).

It's not harder to fix, there's only one occurence of SFML_MSVC_VERSION: in Macros.cmake, line 40.

Member

LaurentGomila commented Oct 15, 2013

Thanks for this new PR.

Well don't you want to change to the VS version then, since you're already using that in the macro as well.
So it would be 2005, 2008, 2010, 2012, 2013. It at least would be easier to fix.

I would really prefer MSVC version. This stuff is about the compiler, not the IDE. And maybe some day we'll see multiple versions of the compiler supported by the same version of the IDE (this was already more or less the case with VS 2012).

It's not harder to fix, there's only one occurence of SFML_MSVC_VERSION: in Macros.cmake, line 40.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 15, 2013

Member

Okay updated it!

Member

eXpl0it3r commented Oct 15, 2013

Okay updated it!

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Oct 15, 2013

Member

You map both version 11 and 12 to MSVC_VERSION 1700, I guess there's a mistake there :p

Member

LaurentGomila commented Oct 15, 2013

You map both version 11 and 12 to MSVC_VERSION 1700, I guess there's a mistake there :p

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 15, 2013

Member

Nope :P

Member

eXpl0it3r commented Oct 15, 2013

Nope :P

@ghost ghost assigned LaurentGomila Oct 15, 2013

LaurentGomila added a commit that referenced this pull request Oct 15, 2013

Merge pull request #482 from eXpl0it3r/master
Added support for VS 2013 and TDM compilers in build files.

@LaurentGomila LaurentGomila merged commit c2a9ed6 into SFML:master Oct 15, 2013

@retep998

This comment has been minimized.

Show comment
Hide comment
@retep998

retep998 Oct 15, 2013

Huzzah, now I don't have to manually fix the project files :D

retep998 commented Oct 15, 2013

Huzzah, now I don't have to manually fix the project files :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment