New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CMake module to provide correct deps on OSX #548

Merged
merged 1 commit into from Apr 23, 2014

Conversation

Projects
None yet
3 participants
@jdpage
Contributor

jdpage commented Mar 11, 2014

libGL doesn't appear to exist on OS X, so I've changed the CMake module to give -framework OpenGL as the dependency, which seems to link correctly.

Adjust CMake module to provide correct deps on OSX
Module will now give the OpenGL framework as a dependency instead of the
nonexistent libGL.

@Bromeon Bromeon added the OS X label Mar 11, 2014

@mantognini mantognini self-assigned this Apr 22, 2014

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Apr 22, 2014

Member

Sorry, I only see this PR now.

@jdpage did you experience issue with the current cmake script?

Member

mantognini commented Apr 22, 2014

Sorry, I only see this PR now.

@jdpage did you experience issue with the current cmake script?

@jdpage

This comment has been minimized.

Show comment
Hide comment
@jdpage

jdpage Apr 23, 2014

Contributor

Yeah, but only because I was compiling statically. Sorry, should have mentioned that. I don't think it's a problem compiling dynamically.

On Tue, Apr 22, 2014 at 6:56 AM, Marco Antognini notifications@github.com
wrote:

Sorry, I only see this PR now.

@jdpage did you experience issue with the current cmake script?

Reply to this email directly or view it on GitHub:
#548 (comment)

Contributor

jdpage commented Apr 23, 2014

Yeah, but only because I was compiling statically. Sorry, should have mentioned that. I don't think it's a problem compiling dynamically.

On Tue, Apr 22, 2014 at 6:56 AM, Marco Antognini notifications@github.com
wrote:

Sorry, I only see this PR now.

@jdpage did you experience issue with the current cmake script?

Reply to this email directly or view it on GitHub:
#548 (comment)

@mantognini mantognini added the resolved label Apr 23, 2014

@mantognini mantognini added this to the 2.2 milestone Apr 23, 2014

mantognini added a commit that referenced this pull request Apr 23, 2014

Merge pull request #548 from jdpage/master
Adjust CMake module to provide correct deps on OSX

@mantognini mantognini merged commit 1ce8a42 into SFML:master Apr 23, 2014

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Apr 23, 2014

Member

Even if I don't recommend using static lib on Mac, since it doesn't break anything I merged your work. Thanks for the PR.

Member

mantognini commented Apr 23, 2014

Even if I don't recommend using static lib on Mac, since it doesn't break anything I merged your work. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment