New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed disabling key repeat on Linux #567

Merged
merged 1 commit into from Apr 7, 2014

Conversation

Projects
None yet
3 participants
@abodelot
Contributor

abodelot commented Apr 7, 2014

This is a fix for issue #564.
Key repeat was broken because the ReparentNotify xevent get stuck when the window is recreated (recreating the window does fire a reparenting xevent).
With this patch, remaining events are discarded upon window recreation. Holding a key down properly fires a KeyRelease xevent followed by a KeyPress xevent, which fixes the mechanism for disabling key repeat.

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Apr 7, 2014

Member

I"m not sure I understand what was happening, but if it solves the problem... that's fine.

Member

LaurentGomila commented Apr 7, 2014

I"m not sure I understand what was happening, but if it solves the problem... that's fine.

LaurentGomila added a commit that referenced this pull request Apr 7, 2014

Merge pull request #567 from abodelot/x11keyrepeat
Fixed disabling key repeat on Linux (#564)

@LaurentGomila LaurentGomila merged commit 2204838 into SFML:master Apr 7, 2014

@LaurentGomila LaurentGomila added this to the 2.2 milestone Apr 7, 2014

@LaurentGomila LaurentGomila self-assigned this Apr 7, 2014

@Bromeon Bromeon added the resolved label Apr 7, 2014

@abodelot abodelot deleted the abodelot:x11keyrepeat branch May 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment