New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed vertical tab support from Text (#442). #588

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@binary1248
Member

binary1248 commented May 12, 2014

No description provided.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini May 12, 2014

Member

Looks good to me.

Member

mantognini commented May 12, 2014

Looks good to me.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 12, 2014

Member

Seems fine to me as well.
Am I right that these escape sequences haven't been documented anywhere? Should there be a note?

Member

eXpl0it3r commented May 12, 2014

Seems fine to me as well.
Am I right that these escape sequences haven't been documented anywhere? Should there be a note?

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 May 12, 2014

Member

The only people who know about them are the ones who either looked at the source, or tried and found out. I don't think many people will miss vertical tabs.

Member

binary1248 commented May 12, 2014

The only people who know about them are the ones who either looked at the source, or tried and found out. I don't think many people will miss vertical tabs.

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila May 12, 2014

Member

Good for me too.

Member

LaurentGomila commented May 12, 2014

Good for me too.

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs May 12, 2014

Member

ACK

Member

TankOs commented May 12, 2014

ACK

@eXpl0it3r eXpl0it3r added this to the 2.2 milestone May 13, 2014

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r
Member

eXpl0it3r commented May 13, 2014

Merged c45039e

@eXpl0it3r eXpl0it3r closed this May 13, 2014

@eXpl0it3r eXpl0it3r added the resolved label May 13, 2014

@eXpl0it3r eXpl0it3r deleted the bugfix/vtab branch May 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment