New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure texture unit 0 is active when reseting RenderTarget states (#5... #591

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@binary1248
Member

binary1248 commented May 12, 2014

...23), fix RenderTarget not clearing when a texture used as a RenderTexture color attachment is left bound in a different context (http://en.sfml-dev.org/forums/index.php?topic=9350.0).

Make sure texture unit 0 is active when reseting RenderTarget states (#…
…523), fix RenderTarget not clearing when a texture used as a RenderTexture color attachment is left bound in a different context (http://en.sfml-dev.org/forums/index.php?topic=9350.0).
@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Apr 29, 2014

Member

Looks good now.

Member

LaurentGomila commented on 132f476 Apr 29, 2014

Looks good now.

@eXpl0it3r eXpl0it3r added this to the 2.2 milestone May 13, 2014

@eXpl0it3r eXpl0it3r added bug labels May 13, 2014

@eXpl0it3r eXpl0it3r modified the milestones: 2.x, 2.2 May 13, 2014

@LaurentGomila LaurentGomila modified the milestones: 2.2, 2.x May 22, 2014

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 22, 2014

Member

Can anyone else that understands OpenGL give it a quick look?

Member

eXpl0it3r commented May 22, 2014

Can anyone else that understands OpenGL give it a quick look?

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch May 22, 2014

Member

Don't see any issue right now.

Member

MarioLiebisch commented May 22, 2014

Don't see any issue right now.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 26, 2014

Member

I couldn't reproduce the original issue with the latest AMD driver, but the reviews seemed to be positive and the examples still work, thus merged in e6b5ce1.

Member

eXpl0it3r commented May 26, 2014

I couldn't reproduce the original issue with the latest AMD driver, but the reviews seemed to be positive and the examples still work, thus merged in e6b5ce1.

@eXpl0it3r eXpl0it3r closed this May 26, 2014

@eXpl0it3r eXpl0it3r deleted the bugfix/render_target_fixes branch May 26, 2014

@eXpl0it3r eXpl0it3r added resolved and removed confirmed labels May 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment