New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindSFML.cmake cache fix #684

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@binary1248
Member

binary1248 commented Aug 19, 2014

Fixes #637 by inserting an intermediate layer so that find_library doesn't save both static and dynamic libraries into variables with the same name, since it caches values based solely on their name.

Fixed FindSFML.cmake not updating library entries when the user chang…
…es the value of SFML_STATIC_LIBRARIES after the initial configure (#637).

@eXpl0it3r eXpl0it3r added bug labels Aug 19, 2014

@eXpl0it3r eXpl0it3r added this to the 2.2 milestone Aug 19, 2014

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Aug 19, 2014

Member

No error is triggered if only static or dynamic libraries are found, and it's what the user requested, right?

Member

LaurentGomila commented Aug 19, 2014

No error is triggered if only static or dynamic libraries are found, and it's what the user requested, right?

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Aug 19, 2014

Member

Yeah... errors are only triggered if the libraries corresponding to the requested link type is not found. The unused entries that are searched for anyway and don't correspond to the requested link type are allowed to contain -NOT_FOUND and are simply ignored. If the user switches, they will be applied and an error will show up.

Member

binary1248 commented Aug 19, 2014

Yeah... errors are only triggered if the libraries corresponding to the requested link type is not found. The unused entries that are searched for anyway and don't correspond to the requested link type are allowed to contain -NOT_FOUND and are simply ignored. If the user switches, they will be applied and an error will show up.

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Aug 19, 2014

Member

Ok so it's fine for me.

Member

LaurentGomila commented Aug 19, 2014

Ok so it's fine for me.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 19, 2014

Member

This PR has been added to my merge list, meaning it will be merged very soon, unless someone raises any concerns.

Member

eXpl0it3r commented Aug 19, 2014

This PR has been added to my merge list, meaning it will be merged very soon, unless someone raises any concerns.

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Aug 26, 2014

Member

Since @eXpl0it3r is at the beach (or something), I merged this. ;)

Member

TankOs commented Aug 26, 2014

Since @eXpl0it3r is at the beach (or something), I merged this. ;)

@TankOs TankOs closed this Aug 26, 2014

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Aug 26, 2014

Member

I haven't looked too closely but github says:

This pull request is closed, but the bugfix/find_sfml_cache branch has unmerged commits.

Do you know why?

Member

mantognini commented Aug 26, 2014

I haven't looked too closely but github says:

This pull request is closed, but the bugfix/find_sfml_cache branch has unmerged commits.

Do you know why?

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Aug 26, 2014

Member

Do you know why?

Because @TankOs is a rebase-kind-of-guy 😁. And since I didn't rebase the branch onto the current master, when he did, GitHub wasn't aware of it and thinks that it is still unmerged, although the rebased version of it really was.

Member

binary1248 commented Aug 26, 2014

Do you know why?

Because @TankOs is a rebase-kind-of-guy 😁. And since I didn't rebase the branch onto the current master, when he did, GitHub wasn't aware of it and thinks that it is still unmerged, although the rebased version of it really was.

@binary1248 binary1248 deleted the bugfix/find_sfml_cache branch Aug 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment