New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/osx memory footprint #698

Merged
merged 1 commit into from Sep 24, 2014

Conversation

Projects
None yet
3 participants
@mantognini
Member

mantognini commented Sep 14, 2014

Patch for #672, ready for review and merge.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 19, 2014

Member

I'll add this to my merge list and way a bit, in hopes someone with OS X can test it.

Member

eXpl0it3r commented Sep 19, 2014

I'll add this to my merge list and way a bit, in hopes someone with OS X can test it.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 23, 2014

Member

This branch seems to have a conflict with some changes from the last commits. Could you take a look @mantognini?

It would also be nice if other Mac user could test/review this.

Member

eXpl0it3r commented Sep 23, 2014

This branch seems to have a conflict with some changes from the last commits. Could you take a look @mantognini?

It would also be nice if other Mac user could test/review this.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 23, 2014

Member

Yep, I'll fix it. I was expecting this conflict (it's this line I guess). Once I've rebase the branche I'll ping you.

Member

mantognini commented Sep 23, 2014

Yep, I'll fix it. I was expecting this conflict (it's this line I guess). Once I've rebase the branche I'll ping you.

@mantognini mantognini self-assigned this Sep 23, 2014

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 23, 2014

Member

@eXpl0it3r should be alright now. Tester would be appreciated, though.

Member

mantognini commented Sep 23, 2014

@eXpl0it3r should be alright now. Tester would be appreciated, though.

@Flowx08

This comment has been minimized.

Show comment
Hide comment
@Flowx08

Flowx08 Sep 23, 2014

@eXpl0it3r Works great here! :)

Flowx08 commented Sep 23, 2014

@eXpl0it3r Works great here! :)

@eXpl0it3r eXpl0it3r merged commit 6d122f4 into master Sep 24, 2014

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 24, 2014

Member

Thanks for testing @Flowx08!

Member

eXpl0it3r commented Sep 24, 2014

Thanks for testing @Flowx08!

@eXpl0it3r eXpl0it3r deleted the bugfix/osx_memory_footprint branch Sep 24, 2014

@mantognini mantognini removed their assignment Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment