New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for OS X 10.10 #699

Merged
merged 1 commit into from Sep 22, 2014

Conversation

Projects
None yet
5 participants
@mantognini
Member

mantognini commented Sep 21, 2014

This is a patch for #691, ready to be tested.

Note: this only fix the compilation process. SFML was not thoroughly
tested on this OS yet.

Added support for OS X 10.10
Note: this only fix the compilation process. SFML was not thoroughly
tested on this OS yet.

@mantognini mantognini added this to the 2.2 milestone Sep 21, 2014

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 21, 2014

Member

@hiramgeeks could you test it and tell me if everything is allright? Thanks.

Member

mantognini commented Sep 21, 2014

@hiramgeeks could you test it and tell me if everything is allright? Thanks.

@hiramgeeks

This comment has been minimized.

Show comment
Hide comment
@hiramgeeks

hiramgeeks Sep 21, 2014

Sure. Have you pushed the changes to some branch? I can test it again if there are also other changes.

Based on the local changes we did last time, it compiles and works perfectly on Yosemite preview.

Enviado do meu iPhone

Em 21/09/2014, às 02:47, Marco Antognini notifications@github.com escreveu:

@hiramgeeks could you test it and tell me if everything is allright? Thanks.


Reply to this email directly or view it on GitHub.

hiramgeeks commented Sep 21, 2014

Sure. Have you pushed the changes to some branch? I can test it again if there are also other changes.

Based on the local changes we did last time, it compiles and works perfectly on Yosemite preview.

Enviado do meu iPhone

Em 21/09/2014, às 02:47, Marco Antognini notifications@github.com escreveu:

@hiramgeeks could you test it and tell me if everything is allright? Thanks.


Reply to this email directly or view it on GitHub.

@hiramgeeks

This comment has been minimized.

Show comment
Hide comment
@hiramgeeks

hiramgeeks Sep 21, 2014

I just saw your commit. I was reading your message by e-mail. Let me test and let you know.

hiramgeeks commented Sep 21, 2014

I just saw your commit. I was reading your message by e-mail. Let me test and let you know.

@hiramgeeks

This comment has been minimized.

Show comment
Hide comment
@hiramgeeks

hiramgeeks Sep 21, 2014

I used the "bugfix/osx_support_10.10" branch. It compiles and run my existent app. Works perfectly. Thanks for your commit(ment) :-)

hiramgeeks commented Sep 21, 2014

I used the "bugfix/osx_support_10.10" branch. It compiles and run my existent app. Works perfectly. Thanks for your commit(ment) :-)

@hiramgeeks

This comment has been minimized.

Show comment
Hide comment
@hiramgeeks

hiramgeeks Sep 21, 2014

Just got 2 warnings that you probably are aware of, but nothing apparently related to that first issue:

[ 32%] Building CXX object src/SFML/Window/CMakeFiles/sfml-window.dir/OSX/HIDInputManager.mm.o
/Users/hiram/Development/SFML/src/SFML/Window/OSX/HIDInputManager.mm:896:2: warning: 
      sf::Keyboard::Tilde might be in conflict with some other key.
      [-W#warnings]
#warning sf::Keyboard::Tilde might be in conflict with some other key.
 ^
/Users/hiram/Development/SFML/src/SFML/Window/OSX/HIDInputManager.mm:988:2: warning: 
      keycode 0x1b is not bound to any key. [-W#warnings]
#warning keycode 0x1b is not bound to any key.
 ^
2 warnings generated.
[ 44%] Building CXX object src/SFML/Window/CMakeFiles/sfml-window.dir/OSX/SFWindowController.mm.o
/Users/hiram/Development/SFML/src/SFML/Window/OSX/SFWindowController.mm:362:58: warning: 
      'convertBaseToScreen:' is deprecated: first deprecated in OS X 10.7 - Use
      -convertRectToScreen: instead [-Wdeprecated-declarations]
    const NSPoint positionInScreen = [[m_oglView window] convertBaseToSc...
                                                         ^
/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:661:1: note: 
      'convertBaseToScreen:' has been explicitly marked deprecated here
- (NSPoint)convertBaseToScreen:(NSPoint)aPoint NS_DEPRECATED_MAC(10_0, 1...
^
1 warning generated. 

hiramgeeks commented Sep 21, 2014

Just got 2 warnings that you probably are aware of, but nothing apparently related to that first issue:

[ 32%] Building CXX object src/SFML/Window/CMakeFiles/sfml-window.dir/OSX/HIDInputManager.mm.o
/Users/hiram/Development/SFML/src/SFML/Window/OSX/HIDInputManager.mm:896:2: warning: 
      sf::Keyboard::Tilde might be in conflict with some other key.
      [-W#warnings]
#warning sf::Keyboard::Tilde might be in conflict with some other key.
 ^
/Users/hiram/Development/SFML/src/SFML/Window/OSX/HIDInputManager.mm:988:2: warning: 
      keycode 0x1b is not bound to any key. [-W#warnings]
#warning keycode 0x1b is not bound to any key.
 ^
2 warnings generated.
[ 44%] Building CXX object src/SFML/Window/CMakeFiles/sfml-window.dir/OSX/SFWindowController.mm.o
/Users/hiram/Development/SFML/src/SFML/Window/OSX/SFWindowController.mm:362:58: warning: 
      'convertBaseToScreen:' is deprecated: first deprecated in OS X 10.7 - Use
      -convertRectToScreen: instead [-Wdeprecated-declarations]
    const NSPoint positionInScreen = [[m_oglView window] convertBaseToSc...
                                                         ^
/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:661:1: note: 
      'convertBaseToScreen:' has been explicitly marked deprecated here
- (NSPoint)convertBaseToScreen:(NSPoint)aPoint NS_DEPRECATED_MAC(10_0, 1...
^
1 warning generated. 
@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 21, 2014

Member

Great! thanks for the input, I was aware of the two first warnings but not the last one. I'll fix it another day.

@eXpl0it3r : it's ready to be merged. :-)

Member

mantognini commented Sep 21, 2014

Great! thanks for the input, I was aware of the two first warnings but not the last one. I'll fix it another day.

@eXpl0it3r : it's ready to be merged. :-)

@hiramgeeks

This comment has been minimized.

Show comment
Hide comment
@hiramgeeks

hiramgeeks Sep 21, 2014

Just FYI: I updated Xcode to 6.0.1 (6A317). It's no longer developer preview. This update have also updated the Cocoa libraries and frameworks.

hiramgeeks commented Sep 21, 2014

Just FYI: I updated Xcode to 6.0.1 (6A317). It's no longer developer preview. This update have also updated the Cocoa libraries and frameworks.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 21, 2014

Member

Right they published it this week. I just tested Xcode 6, it seems to run smoothly. Good news for me: the templates system still works. :D

Member

mantognini commented Sep 21, 2014

Right they published it this week. I just tested Xcode 6, it seems to run smoothly. Good news for me: the templates system still works. :D

@eXpl0it3r eXpl0it3r merged commit 2427aaf into master Sep 22, 2014

@eXpl0it3r eXpl0it3r deleted the bugfix/osx_support_10.10 branch Sep 22, 2014

@Ceylo

This comment has been minimized.

Show comment
Hide comment
@Ceylo

Ceylo Sep 22, 2014

Contributor

I'm curious about why this change was needed. NSApp definition has changed?

Contributor

Ceylo commented on src/SFML/Window/OSX/WindowImplCocoa.mm in 2427aaf Sep 22, 2014

I'm curious about why this change was needed. NSApp definition has changed?

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Sep 22, 2014

Member

Yes, see #691

Member

LaurentGomila replied Sep 22, 2014

Yes, see #691

This comment has been minimized.

Show comment
Hide comment
@Ceylo

Ceylo Sep 22, 2014

Contributor

Indeed, thanks :)

Contributor

Ceylo replied Sep 22, 2014

Indeed, thanks :)

@mantognini mantognini removed their assignment Apr 30, 2015

@mantognini mantognini self-assigned this Feb 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment