New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flexibility of dependencies' locations on OS X #713

Merged
merged 2 commits into from Oct 9, 2014

Conversation

Projects
None yet
4 participants
@mantognini
Member

mantognini commented Oct 7, 2014

This PR might break the installation procedure of bindings (especially if it involves using install_name_tool to "fix" paths). But it should not be insurmountable.

Anyway, this fixes feature/unittest and is required for working on feature/no_libsndfile.

mantognini added some commits Oct 7, 2014

Improve flexibility of dependencies locations on OS X
 - Replaced @executable_path by @rpath for more flexibility
 - Updated freetype and sndfile libs as follow:

    install_name_tool -id "@rpath/../Frameworks/freetype.framework/Versions/A/freetype" freetype
    install_name_tool -id "@rpath/../Frameworks/sndfile.framework/Versions/A/sndfile" sndfile
Updated Xcode templates
Since the @loader_path was replaced with @rpath, to correctly load
binaries from within a bundle app we need to add the Frameworks
subdirectory to the run path list.
@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Oct 7, 2014

Member

So basically when this is merged both feature/unittest and feature/no_libsndfile should be rebased onto master.

Member

mantognini commented Oct 7, 2014

So basically when this is merged both feature/unittest and feature/no_libsndfile should be rebased onto master.

@mantognini mantognini added this to the 2.2 milestone Oct 7, 2014

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Oct 7, 2014

Member

You should definitely leave a commit at the corresponding PRs. Thanks. :)

Member

TankOs commented Oct 7, 2014

You should definitely leave a commit at the corresponding PRs. Thanks. :)

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Oct 7, 2014

Member

What do you mean?

Member

mantognini commented Oct 7, 2014

What do you mean?

@zsbzsb

This comment has been minimized.

Show comment
Hide comment
@zsbzsb

zsbzsb Oct 7, 2014

Member

@mantognini I think @TankOs meant to say 'comment'.

Member

zsbzsb commented Oct 7, 2014

@mantognini I think @TankOs meant to say 'comment'.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Oct 8, 2014

Member

But we don't have PRs for unittest or no_libsndfile yet. So where should I leave a comment then?

Member

mantognini commented Oct 8, 2014

But we don't have PRs for unittest or no_libsndfile yet. So where should I leave a comment then?

@@ -127,6 +127,9 @@ subject to the following restrictions:
<dict>
<key>INFOPLIST_FILE</key>
<string>___PACKAGENAME___/___PACKAGENAME___-Info.plist</string>

This comment has been minimized.

@eXpl0it3r

eXpl0it3r Oct 9, 2014

Member

Do you want this empty line here? (Not that it would matter...)

@eXpl0it3r

eXpl0it3r Oct 9, 2014

Member

Do you want this empty line here? (Not that it would matter...)

This comment has been minimized.

@mantognini

mantognini Oct 9, 2014

Member

Yep, I prefer to separate each <key> visually if they are not directly related to each other. :-)

@mantognini

mantognini Oct 9, 2014

Member

Yep, I prefer to separate each <key> visually if they are not directly related to each other. :-)

@eXpl0it3r eXpl0it3r merged commit 9a8ba74 into master Oct 9, 2014

@eXpl0it3r eXpl0it3r deleted the feature/rpath_osx branch Oct 9, 2014

@eXpl0it3r eXpl0it3r added the s:accepted label Oct 9, 2014

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Oct 9, 2014

Member

👍 thx

Member

mantognini commented Oct 9, 2014

👍 thx

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Oct 9, 2014

Member

@mantognini Haha indeed -- I guess #623 should do as well. 🌹

Member

TankOs commented Oct 9, 2014

@mantognini Haha indeed -- I guess #623 should do as well. 🌹

@mantognini mantognini removed their assignment Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment