New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FindSFML to add UDev to SFML's dependencies #729

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@MarioLiebisch
Member

MarioLiebisch commented Oct 23, 2014

This fixes issue #728 - tested on Linux Mint X64.

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Oct 30, 2014

Member

Rewrote the initial PR from scratch, properly sets the library for me now during all tests.

Member

MarioLiebisch commented Oct 30, 2014

Rewrote the initial PR from scratch, properly sets the library for me now during all tests.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 30, 2014

Member

Did you allow OpenGL ES builds on non-Linux platforms intentionally L210? Does it even work?

if(SFML_OPENGL_ES AND SFML_OS_LINUX)

vs

if(SFML_OPENGL_ES)

Member

eXpl0it3r commented Oct 30, 2014

Did you allow OpenGL ES builds on non-Linux platforms intentionally L210? Does it even work?

if(SFML_OPENGL_ES AND SFML_OS_LINUX)

vs

if(SFML_OPENGL_ES)

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Oct 30, 2014

Member

I thought it's actually a bug so changed that line as well. Can revert it, in case it's indeed intentional.

Member

MarioLiebisch commented Oct 30, 2014

I thought it's actually a bug so changed that line as well. Can revert it, in case it's indeed intentional.

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Oct 30, 2014

Member

I don't know if this is a bug or not, but it's better to avoid mixing several fixes into a single PR. This one is about UDev, let's keep OpenGL ES stuff for another task.

Member

LaurentGomila commented Oct 30, 2014

I don't know if this is a bug or not, but it's better to avoid mixing several fixes into a single PR. This one is about UDev, let's keep OpenGL ES stuff for another task.

Show outdated Hide outdated src/SFML/Window/CMakeLists.txt Outdated
Reworked the UDev inclusion
* This fixes `SFML_DEPENDENCIES` missing the UDev library for static builds (issue #728).
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Nov 3, 2014

Member

Can someone test this on a native Linux? Once I get confirmed tests, I'll merge it.

Member

eXpl0it3r commented Nov 3, 2014

Can someone test this on a native Linux? Once I get confirmed tests, I'll merge it.

@danijar

This comment has been minimized.

Show comment
Hide comment
@danijar

danijar Nov 5, 2014

Contributor

Tested under Ubuntu 14.04 virtual machine and works fine. Unfortunately, I have no native Linux machine at the moment.

Contributor

danijar commented Nov 5, 2014

Tested under Ubuntu 14.04 virtual machine and works fine. Unfortunately, I have no native Linux machine at the moment.

@eXpl0it3r eXpl0it3r added this to the 2.2 milestone Nov 5, 2014

@eXpl0it3r eXpl0it3r self-assigned this Nov 5, 2014

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Nov 6, 2014

Member

Merged in 1271dff, thanks for the PR!

Member

eXpl0it3r commented Nov 6, 2014

Merged in 1271dff, thanks for the PR!

@eXpl0it3r eXpl0it3r closed this Nov 6, 2014

@MarioLiebisch MarioLiebisch deleted the MarioLiebisch:udev-dependencies branch Nov 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment