New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed right click not detected on OS X with trackpads #730

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mantognini
Member

mantognini commented Oct 25, 2014

This is a patch for OSX Trackpad Right Click Not Triggered #716.

Fixed right click not detected on OS X with trackpads, close #716
Now that `+[NSEvent pressedMouseButtons]` can be used, part of HIDInputManager becomes obsolete and is therefore removed.
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 27, 2014

Member

I've added this PR on my merge list, it would be great if some OS X people could test it, especially @tehnugget

Member

eXpl0it3r commented Oct 27, 2014

I've added this PR on my merge list, it would be great if some OS X people could test it, especially @tehnugget

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Oct 29, 2014

Member

@tehnugget Would be awesome if you could test this! 😉

Member

eXpl0it3r commented Oct 29, 2014

@tehnugget Would be awesome if you could test this! 😉

@pnappa

This comment has been minimized.

Show comment
Hide comment
@pnappa

pnappa Nov 2, 2014

It doesn't seem to work when cloning the latest source from the repo and compiling it. It may be a problem on my end, but it does seem to have installed correctly. Is there anyway I can find the version of a linked library in a program to double check?

pnappa commented Nov 2, 2014

It doesn't seem to work when cloning the latest source from the repo and compiling it. It may be a problem on my end, but it does seem to have installed correctly. Is there anyway I can find the version of a linked library in a program to double check?

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Nov 2, 2014

Member

You can check the actual library loaded at runtime with lldb as follow:

$ lldb myApp
(lldb) run       # and quit your app, or ctrl+c to pause it
(lldb) target modules list libsfml-window.2.dylib

The last instruction should be replaced by target modules list sfml-window if you're using frameworks instead of dylibs.

NB: otool cannot be used to get the full path. For example, you can get something like @rpath/libsfml-system.2.dylib

Member

mantognini commented Nov 2, 2014

You can check the actual library loaded at runtime with lldb as follow:

$ lldb myApp
(lldb) run       # and quit your app, or ctrl+c to pause it
(lldb) target modules list libsfml-window.2.dylib

The last instruction should be replaced by target modules list sfml-window if you're using frameworks instead of dylibs.

NB: otool cannot be used to get the full path. For example, you can get something like @rpath/libsfml-system.2.dylib

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Nov 2, 2014

Member

It doesn't seem to work when cloning the latest source from the repo and compiling it.

Did you make sure to check out the bugfix/trackpad_osx branch?

Member

eXpl0it3r commented Nov 2, 2014

It doesn't seem to work when cloning the latest source from the repo and compiling it.

Did you make sure to check out the bugfix/trackpad_osx branch?

@pnappa

This comment has been minimized.

Show comment
Hide comment
@pnappa

pnappa Nov 3, 2014

Oops. I misread the merge at the top of the page.

I can confirm the branch fixes the problem, at least as far as I can tell!

pnappa commented Nov 3, 2014

Oops. I misread the merge at the top of the page.

I can confirm the branch fixes the problem, at least as far as I can tell!

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Nov 3, 2014

Member

@tehnugget great! Thanks for testing.

Member

mantognini commented Nov 3, 2014

@tehnugget great! Thanks for testing.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Nov 3, 2014

Member

Thanks for testing!

Merged in 8928baa

Member

eXpl0it3r commented Nov 3, 2014

Thanks for testing!

Merged in 8928baa

@eXpl0it3r eXpl0it3r closed this Nov 3, 2014

@eXpl0it3r eXpl0it3r deleted the bugfix/trackpad_osx branch Nov 3, 2014

@mantognini mantognini removed their assignment Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment