New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples adjustments. #737

Merged
merged 1 commit into from Nov 17, 2014

Conversation

Projects
None yet
6 participants
@TankOs
Member

TankOs commented Nov 17, 2014

  • French to English punctuation.
  • Pong and Shader use fixed-sized windows now (especially on tiling window managers, the windows will be resized automatically, thus making the examples look and also behave weirdly).
Examples adjustments.
* French to English punctuation.
* Pong and Shader use fixed-sized windows now (especially on tiling
  window managers, the windows will be resized automatically, thus
  making the examples look and also behave weirdly).
@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Nov 17, 2014

Member

Looks good to me.

Member

mantognini commented Nov 17, 2014

Looks good to me.

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Nov 17, 2014

Member

👍

Member

binary1248 commented Nov 17, 2014

👍

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila
Member

LaurentGomila commented Nov 17, 2014

👍

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Nov 17, 2014

Member

Should this be added for SFML 2.2?

Member

eXpl0it3r commented Nov 17, 2014

Should this be added for SFML 2.2?

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Nov 17, 2014

Member

I don't think it's a critical change, and a lot of people have already tested the current examples. Maybe we should test things thoroughly, I always have a bad feeling at last-minute additions, even seemingly harmless ones... ;)
Otherwise there is also the bugfix/size_t branch...

Member

Bromeon commented Nov 17, 2014

I don't think it's a critical change, and a lot of people have already tested the current examples. Maybe we should test things thoroughly, I always have a bad feeling at last-minute additions, even seemingly harmless ones... ;)
Otherwise there is also the bugfix/size_t branch...

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Nov 17, 2014

Member

These changes aren't to the SFML code base itself and if they don't work as expected, then we'd have a bug in SFML which should be fixed as soon as possible anyways. Thus "last minute" doesn't really apply here, as opposed to changing SFML library code and "playing" around with types. 😉

Member

eXpl0it3r commented Nov 17, 2014

These changes aren't to the SFML code base itself and if they don't work as expected, then we'd have a bug in SFML which should be fixed as soon as possible anyways. Thus "last minute" doesn't really apply here, as opposed to changing SFML library code and "playing" around with types. 😉

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Nov 17, 2014

Member

I'd say we include it to 2.2 since a) we've asked the community for some feedback before releasing 2.2 and it would be strange to say "thanks, it will be fixed in 2.3" (for minor stuff) b) it's sooo minor (and as @eXpl0it3r said, doesn't impact SFML itself). Regarding size_t, I'd say yes too, but only for reason a) of course.

Member

mantognini commented Nov 17, 2014

I'd say we include it to 2.2 since a) we've asked the community for some feedback before releasing 2.2 and it would be strange to say "thanks, it will be fixed in 2.3" (for minor stuff) b) it's sooo minor (and as @eXpl0it3r said, doesn't impact SFML itself). Regarding size_t, I'd say yes too, but only for reason a) of course.

@TankOs TankOs added this to the 2.2 milestone Nov 17, 2014

@TankOs TankOs added s:accepted and removed s:unassigned labels Nov 17, 2014

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Nov 17, 2014

Member

You convinced me, let's add it :)

About size_t, I'll open a PR, so we can discuss there.

Member

Bromeon commented Nov 17, 2014

You convinced me, let's add it :)

About size_t, I'll open a PR, so we can discuss there.

@eXpl0it3r eXpl0it3r self-assigned this Nov 17, 2014

@eXpl0it3r eXpl0it3r merged commit 40ae3ce into master Nov 17, 2014

@eXpl0it3r eXpl0it3r deleted the bugfix/examples branch Nov 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment