New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide CMake success message in quiet mode #753

Merged
merged 1 commit into from Dec 24, 2014

Conversation

Projects
None yet
3 participants
@danijar
Contributor

danijar commented Dec 19, 2014

I think the success message shouldn't be printed when using find_package(SFML 2 QUIET). For example, I want to print a custom success message if SFML_FOUND. This way, I can have success messages of the same format for all dependencies.

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Dec 20, 2014

Member

Looks good.

Member

LaurentGomila commented Dec 20, 2014

Looks good.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Dec 20, 2014

Member

To be consistent you should remove the parentheses.
CMake has no problem working with if(a AND NOT b).

Member

eXpl0it3r commented Dec 20, 2014

To be consistent you should remove the parentheses.
CMake has no problem working with if(a AND NOT b).

@danijar

This comment has been minimized.

Show comment
Hide comment
@danijar

danijar Dec 21, 2014

Contributor

Parentheses removed.

Contributor

danijar commented Dec 21, 2014

Parentheses removed.

@eXpl0it3r eXpl0it3r self-assigned this Dec 21, 2014

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Dec 21, 2014

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Dec 21, 2014

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit f44c903 into SFML:master Dec 24, 2014

@danijar danijar deleted the danijar:bugfix/cmake_quiet branch Dec 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment