New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in JoystickImpl.cpp to prevent crash on OS X #765

Merged
merged 1 commit into from Jan 10, 2015

Conversation

Projects
None yet
3 participants
@mantognini
Member

mantognini commented Jan 6, 2015

Supersedes #762.

Read for review/testing.

@executionunit, could you test it?

@mantognini mantognini added this to the 2.3 milestone Jan 6, 2015

@mantognini mantognini self-assigned this Jan 6, 2015

@executionunit

This comment has been minimized.

Show comment
Hide comment
@executionunit

executionunit Jan 7, 2015

Can confirm this works as expected. Thanks.

On 6 Jan 2015, at 23:33, Marco Antognini notifications@github.com wrote:

Supersedes #762 #762.

Read for review/testing.

@executionunit https://github.com/executionunit, could you test it?

You can merge this Pull Request by running

git pull https://github.com/LaurentGomila/SFML bugfix/joystick_osx
Or view, comment on, or merge it at:

#765 #765
Commit Summary

Fixed typo in JoystickImpl.cpp to prevent crash on OS X
File Changes

M src/SFML/Window/OSX/JoystickImpl.cpp https://github.com/LaurentGomila/SFML/pull/765/files#diff-0 (4)
Patch Links:

https://github.com/LaurentGomila/SFML/pull/765.patch https://github.com/LaurentGomila/SFML/pull/765.patch
https://github.com/LaurentGomila/SFML/pull/765.diff https://github.com/LaurentGomila/SFML/pull/765.diff

Reply to this email directly or view it on GitHub #765.

executionunit commented Jan 7, 2015

Can confirm this works as expected. Thanks.

On 6 Jan 2015, at 23:33, Marco Antognini notifications@github.com wrote:

Supersedes #762 #762.

Read for review/testing.

@executionunit https://github.com/executionunit, could you test it?

You can merge this Pull Request by running

git pull https://github.com/LaurentGomila/SFML bugfix/joystick_osx
Or view, comment on, or merge it at:

#765 #765
Commit Summary

Fixed typo in JoystickImpl.cpp to prevent crash on OS X
File Changes

M src/SFML/Window/OSX/JoystickImpl.cpp https://github.com/LaurentGomila/SFML/pull/765/files#diff-0 (4)
Patch Links:

https://github.com/LaurentGomila/SFML/pull/765.patch https://github.com/LaurentGomila/SFML/pull/765.patch
https://github.com/LaurentGomila/SFML/pull/765.diff https://github.com/LaurentGomila/SFML/pull/765.diff

Reply to this email directly or view it on GitHub #765.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Jan 7, 2015

Member

Great!

Member

mantognini commented Jan 7, 2015

Great!

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jan 9, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Jan 9, 2015

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit 8a8793e into master Jan 10, 2015

@eXpl0it3r eXpl0it3r deleted the bugfix/joystick_osx branch Jan 10, 2015

@mantognini mantognini removed their assignment Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment