New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a FLAC file to the Sound example to cover all three supported formats. #815

Merged
merged 1 commit into from Mar 28, 2015

Conversation

Projects
None yet
5 participants
@eXpl0it3r
Member

eXpl0it3r commented Mar 9, 2015

Now that we're down to three supported formats, we should also "test" all of them in the example.

Show outdated Hide outdated examples/sound/Sound.cpp Outdated
Show outdated Hide outdated examples/sound/Sound.cpp Outdated
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 10, 2015

Member

Currently doesn't play due to #814 otherwise I adjusted the PR according to the comments (FLAC reference).

Member

eXpl0it3r commented Mar 10, 2015

Currently doesn't play due to #814 otherwise I adjusted the PR according to the comments (FLAC reference).

Show outdated Hide outdated examples/sound/Sound.cpp Outdated
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 10, 2015

Member

Fixed.

Member

eXpl0it3r commented Mar 10, 2015

Fixed.

@zsbzsb

This comment has been minimized.

Show comment
Hide comment
@zsbzsb

zsbzsb Mar 25, 2015

Member

👍

Member

zsbzsb commented Mar 25, 2015

👍

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 25, 2015

Member

Can we add this to 2.3?

Member

eXpl0it3r commented Mar 25, 2015

Can we add this to 2.3?

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Mar 26, 2015

Member

Why not ;)

Code is simple and clean. Good for me.

Member

mantognini commented Mar 26, 2015

Why not ;)

Code is simple and clean. Good for me.

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Mar 26, 2015

Member

This should be rebased onto master (maybe even after the merge of bugfix/findsfml_fixes). I can't build this version with CMake because of the wrong FreeType paths.

Member

Bromeon commented Mar 26, 2015

This should be rebased onto master (maybe even after the merge of bugfix/findsfml_fixes). I can't build this version with CMake because of the wrong FreeType paths.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Mar 26, 2015

Member

I wonder how you build things, because it works perfectly fine for me, but I'll certainly rebase it. 😄

Member

eXpl0it3r commented Mar 26, 2015

I wonder how you build things, because it works perfectly fine for me, but I'll certainly rebase it. 😄

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Mar 26, 2015

Member

Funny 😀 In the log graph, it was visible that feature/example_flac was based on a commit before the Freetype change. Maybe an old version? Although I did pull...

In any case, it works now, the FLAC file plays 👍

Member

Bromeon commented Mar 26, 2015

Funny 😀 In the log graph, it was visible that feature/example_flac was based on a commit before the Freetype change. Maybe an old version? Although I did pull...

In any case, it works now, the FLAC file plays 👍

@eXpl0it3r eXpl0it3r added s:accepted and removed s:undecided labels Mar 26, 2015

@eXpl0it3r eXpl0it3r added this to the 2.3 milestone Mar 26, 2015

@eXpl0it3r eXpl0it3r merged commit 20f213b into master Mar 28, 2015

@eXpl0it3r eXpl0it3r deleted the feature/example_flac branch Mar 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment