New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the window still exists before we access the dimensions on it #854

Closed
wants to merge 1 commit into
base: master
from

Conversation

5 participants
@tiaanl
Contributor

tiaanl commented Mar 31, 2015

If you have the native window in landscape view and you open another view from it in portrait, on some devices we get a onDestroyNativeWindow (which sets states->window to NULL) and then afterwards we receive a onContentRectChanged that tries to access values on that window that was just destroyed.

@MarioLiebisch MarioLiebisch added this to the 2.3.1 milestone May 12, 2015

@eXpl0it3r eXpl0it3r self-assigned this May 12, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 12, 2015

Member

This PR has been added to my merge list, meaning it will be merged into 2.3.x soon, unless someone raises any concerns.

Member

eXpl0it3r commented May 12, 2015

This PR has been added to my merge list, meaning it will be merged into 2.3.x soon, unless someone raises any concerns.

states->forwardEvent(event);
// Make sure the window still exists before we access the dimensions on it
if (states->window != NULL) {

This comment has been minimized.

@TankOs

TankOs May 13, 2015

Member

AFAIK SFML convention is if (states->window), but besides of that it looks good.

@TankOs

TankOs May 13, 2015

Member

AFAIK SFML convention is if (states->window), but besides of that it looks good.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 22, 2015

Member

Merged in 46a625d on branch 2.3.x

Member

eXpl0it3r commented May 22, 2015

Merged in 46a625d on branch 2.3.x

@eXpl0it3r eXpl0it3r closed this May 22, 2015

@eXpl0it3r eXpl0it3r added this to Done in Android Backlog Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment